Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleRetryHandler doesn't use the CancellationToken when sleeping #1031

Closed
ColinBradley opened this issue Mar 22, 2025 · 0 comments · Fixed by #1032
Closed

SimpleRetryHandler doesn't use the CancellationToken when sleeping #1031

ColinBradley opened this issue Mar 22, 2025 · 0 comments · Fixed by #1032

Comments

@ColinBradley
Copy link
Contributor

ColinBradley commented Mar 22, 2025 •
edited
Loading

This means you can get stuck inside of a retry.
Should be a simple case of passing the token in during sleep and allowing sleep methods that take it in.
I've put up a fix - should still be compatible with old usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SimpleRetryHandler - sleep now uses CancellationToken ColinBradley/SpotifyAPI-NET
1 participant
@ColinBradley