From 1a8693214257f34be0327d636ec13809d82e6bd8 Mon Sep 17 00:00:00 2001 From: Daniel Spaude Date: Thu, 9 Jun 2022 11:20:51 +0200 Subject: [PATCH] fix(258): improve useEffect call * add missing dependencies * add additional effect which stops the scanner when the component unmounts --- src/QrReader/hooks.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/QrReader/hooks.ts b/src/QrReader/hooks.ts index 0d26fdc..d00d1c8 100644 --- a/src/QrReader/hooks.ts +++ b/src/QrReader/hooks.ts @@ -43,7 +43,9 @@ export const useQrReader: UseQrReaderHook = ({ } }); } + }, [delayBetweenScanAttempts, onResult, video, videoId]); + useEffect(() => { return () => { controlsRef.current?.stop(); };