Skip to content

Commit db1467c

Browse files
committed
Having "cache" or "store" in credentials manager config does not longer throw an error
1 parent 07e98da commit db1467c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.jetpackduba.gitnuro.credentials
22

33
import com.jetpackduba.gitnuro.exceptions.NotSupportedHelper
44
import com.jetpackduba.gitnuro.git.remote_operations.CredentialsCache
5+
import com.jetpackduba.gitnuro.logging.printError
56
import com.jetpackduba.gitnuro.logging.printLog
67
import com.jetpackduba.gitnuro.managers.IShellManager
78
import com.jetpackduba.gitnuro.repositories.AppSettingsRepository
@@ -259,7 +260,8 @@ class HttpCredentialsProvider @AssistedInject constructor(
259260
val credentialHelperPath = uriSpecificCredentialHelper ?: genericCredentialHelper ?: return null
260261

261262
if (credentialHelperPath == "cache" || credentialHelperPath == "store") {
262-
throw NotSupportedHelper("Invalid credentials helper: \"$credentialHelperPath\" is not yet supported")
263+
printError(TAG, "Invalid credentials helper: \"$credentialHelperPath\" is not yet supported")
264+
return null
263265
}
264266

265267
// TODO Try to use "git-credential-manager-core" when "manager-core" is detected. Works for linux but requires testing for mac/windows

0 commit comments

Comments
 (0)