Corrected XMLElement.getChildren(name): was returning all descendants with that tag name#1
Open
sorin-postelnicu wants to merge 1 commit intoJeffreyRodriguez:masterfrom
Open
Conversation
…getElementsByTagName(name) which returns all descendants with that tag name, instead of returning only the direct children with that tag name. In the corrected version, XMLElement.getChildren(name) will return only the direct children with that tag name. Also created a new method called XMLElement.getDescendants(name), which returns all descendants with that tag name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected XMLElement.getChildren(name), because it was using method getElementsByTagName, which returns all descendants with that tag name, instead of returning only the direct children with that tag name.
In the corrected version, XMLElement.getChildren(name) will return only the direct children with that tag name.
Also created a new method called XMLElement.getDescendants(name), which returns all descendants with that tag name.