Skip to content

Commit 1aed7ba

Browse files
committed
[GR-30451] Reintroduce the dependency to the Graal.js component.
PullRequest: js/1961
2 parents df4292a + 4070775 commit 1aed7ba

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

graal-nodejs/mx.graal-nodejs/mx_graal_nodejs.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -591,15 +591,7 @@ def mx_post_parse_cmd_line(args):
591591
dir_name='nodejs',
592592
license_files=[],
593593
third_party_license_files=[],
594-
# TODO (GR-30451): generate gu metadata for installable components that are included in the base image and make the
595-
# Graal.nodejs component depend on Graal.js.
596-
# To generate the Graal.js standalone, the Graal.js component must have `installable=True`. However:
597-
# 1. Graal.js is part of all base GraalVM images that we publish;
598-
# 2. We do not generate gu metadata for installable components that are part of the base image (GR-30451);
599-
# 3. We do not publish a Graal.js installable.
600-
# As a consequence, if the Graal.nodejs component depended on Graal.js, gu would not be able to resolve the
601-
# dependency at component-installation time.
602-
dependencies=[],
594+
dependencies=['Graal.js'],
603595
truffle_jars=['graal-nodejs:TRUFFLENODE'],
604596
support_distributions=['graal-nodejs:TRUFFLENODE_GRAALVM_SUPPORT'],
605597
provided_executables=[

0 commit comments

Comments
 (0)