Skip to content

Commit 0aca734

Browse files
committed
remove empty method from TestSuite
1 parent 47a8348 commit 0aca734

File tree

5 files changed

+3
-20
lines changed

5 files changed

+3
-20
lines changed

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/nashorn/TestNashorn.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,6 @@ public TestRunnable createTestRunnable(TestFile file) {
9191
return new TestNashornRunnable(this, file);
9292
}
9393

94-
@Override
95-
protected void setupTestFile(TestFile testFile) {
96-
}
97-
9894
@Override
9995
protected File getTestsConfigFile() {
10096
return Paths.get(getConfig().getSuiteConfigLoc(), TESTS_CONFIG_FILE).toFile();

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/suite/TestSuite.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@ public Engine getSharedEngine() {
151151

152152
protected abstract TestRunnable createTestRunnable(TestFile file);
153153

154-
protected abstract void setupTestFile(TestFile testFile);
155-
156154
protected abstract File getTestsConfigFile();
157155

158156
protected abstract File getUnexpectedlyFailedTestsFile();
@@ -348,7 +346,6 @@ private TestFile createTestFile(File file) {
348346
TestFile testFile = new TestFile(relativizeTestPath(file));
349347
testFile.setStatus(TestFile.Status.PASS);
350348
testFile.setRunInIsolation(false);
351-
setupTestFile(testFile);
352349
// possibly merge with config
353350
final String filePath = testFile.getFilePath();
354351
TestFile configuredTestFile = testsConfig.get(filePath);

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/test262/Test262.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,6 @@ public TestRunnable createTestRunnable(TestFile file) {
140140
return new Test262Runnable(this, file);
141141
}
142142

143-
@Override
144-
protected void setupTestFile(TestFile testFile) {
145-
}
146-
147143
@Override
148144
protected File getTestsConfigFile() {
149145
return Paths.get(getConfig().getSuiteConfigLoc(), TESTS_CONFIG_FILE).toFile();

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/testv8/TestV8.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,6 @@ public TestRunnable createTestRunnable(TestFile file) {
128128
return new TestV8Runnable(this, file);
129129
}
130130

131-
@Override
132-
protected void setupTestFile(TestFile testFile) {
133-
}
134-
135131
@Override
136132
protected File getTestsConfigFile() {
137133
return Paths.get(getConfig().getSuiteConfigLoc(), TESTS_CONFIG_FILE).toFile();

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/nashorn/HereDocumentTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,23 +52,21 @@
5252

5353
public class HereDocumentTest {
5454
private static String testIntl(String sourceText) {
55-
try (Context context = JSTest.newContextBuilder().option(JSContextOptions.NASHORN_COMPATIBILITY_MODE_NAME, "true").option(JSContextOptions.SCRIPTING_NAME, "true").allowAllAccess(
56-
true).build()) {
57-
Value result = context.eval(Source.newBuilder(JavaScriptLanguage.ID, sourceText, "javaadapter-test").buildLiteral());
55+
try (Context context = JSTest.newContextBuilder().option(JSContextOptions.NASHORN_COMPATIBILITY_MODE_NAME, "true").option(JSContextOptions.SCRIPTING_NAME, "true").build()) {
56+
Value result = context.eval(Source.newBuilder(JavaScriptLanguage.ID, sourceText, "here-document-test").buildLiteral());
5857
Assert.assertTrue(result.isString());
5958
return result.asString();
6059
}
6160
}
6261

6362
@Test
64-
public void javaAdapterTest() {
63+
public void hereDocumentTest() {
6564
String sourceCode = "var str = <<EOD\n" +
6665
"line1\n" +
6766
" line2\n" +
6867
" line3\n" +
6968
"EOD\n" +
7069
"str;";
71-
7270
Assert.assertEquals("line1\n line2\n line3", testIntl(sourceCode));
7371
}
7472
}

0 commit comments

Comments
 (0)