fix: Ensure arguments are targeted correctly

fix: Added a missing jsdoc

Author: robertleeplummerjr

dist/gpu-browser-core.js

@@ -4,8 +4,8 @@
  *
  * GPU Accelerated JavaScript
  *
- * @version 2.10.5
- * @date Thu Nov 12 2020 14:04:03 GMT-0500 (Eastern Standard Time)
+ * @version 2.10.6
+ * @date Wed Dec 02 2020 15:14:25 GMT-0500 (Eastern Standard Time)
  *
  * @license MIT
  * The MIT License
@@ -2555,7 +2555,6 @@ class FunctionBuilder {
 module.exports = {
   FunctionBuilder
 };
-
 },{}],9:[function(require,module,exports){
 const acorn = require('acorn');
 const { utils } = require('../utils');
@@ -10381,7 +10380,7 @@ class WebGLKernel extends GLKernel {
       return this.createTexture();
     };
     const onRequestIndex = () => {
-      return textureIndexes++;
+      return this.constantTextureCount + textureIndexes++;
     };
     const onUpdateValueMismatch = (constructor) => {
       this.switchKernels({

dist/gpu-browser-core.min.js

@@ -1,6 +1,6 @@
 {
   "name": "gpu.js",
-  "version": "2.10.5",
+  "version": "2.10.6",
   "description": "GPU Accelerated JavaScript",
   "engines": {
     "node": ">=8.0.0"

dist/gpu-browser.js

@@ -98,6 +98,14 @@ class WebGLKernel extends GLKernel {
     return testContext.getParameter(testContext.MAX_TEXTURE_SIZE);
   }
 
+  /**
+   *
+   * @param type
+   * @param dynamic
+   * @param precision
+   * @param value
+   * @returns {KernelValue}
+   */
   static lookupKernelValueType(type, dynamic, precision, value) {
     return lookupKernelValueType(type, dynamic, precision, value);
   }
@@ -364,7 +372,7 @@ class WebGLKernel extends GLKernel {
       return this.createTexture();
     };
     const onRequestIndex = () => {
-      return textureIndexes++;
+      return this.constantTextureCount + textureIndexes++;
     };
     const onUpdateValueMismatch = (constructor) => {
       this.switchKernels({

dist/gpu-browser.min.js

@@ -180,6 +180,7 @@
 <script type="module" src="issues/567-wrong-modulus.js"></script>
 <script type="module" src="issues/585-inaccurate-lookups.js"></script>
 <script type="module" src="issues/586-unable-to-resize.js"></script>
+<script type="module" src="issues/608-rewritten-arrays.js"></script>
 <script type="module" src="issues/91-create-kernel-map-array.js"></script>
 <script type="module" src="issues/96-param-names.js"></script>
 <script type="module" src="features/to-string/as-file.js"></script>

package-lock.json

@@ -0,0 +1,77 @@
+const { assert, skip, test, module: describe, only } = require('qunit');
+const { GPU } = require('../../src');
+
+describe('issue #608 - rewritten arrays');
+
+function testRewrittenArrays(mode) {
+  const gpu = new GPU({ mode });
+  const kernel1 = gpu.createKernel(function (a, b) {
+    return a[this.thread.y][this.thread.x];
+  }, {
+    constants: {
+      c: [21, 23]
+    },
+    output: [2, 2]
+  });
+  const kernel2 = gpu.createKernel(function (a, b) {
+    return b[this.thread.y][this.thread.x];
+  }, {
+    constants: {
+      c: [21, 23]
+    },
+    output: [2, 2]
+  });
+  const kernel3 = gpu.createKernel(function (a, b) {
+    return this.constants.c[this.thread.x];
+  }, {
+    constants: {
+      c: [21, 23]
+    },
+    output: [2, 2]
+  });
+  const a = [
+    [2, 3],
+    [5, 7]
+  ];
+  const b = [
+    [11, 13],
+    [17, 19]
+  ];
+  const cExpected = [
+    [21, 23],
+    [21, 23]
+  ];
+  // testing twice to ensure constants are reset
+  assert.deepEqual(kernel1(a, b).map(v => Array.from(v)), a);
+  assert.deepEqual(kernel2(a, b).map(v => Array.from(v)), b);
+  assert.deepEqual(kernel3(a, b).map(v => Array.from(v)), cExpected);
+
+  assert.deepEqual(kernel1(a, b).map(v => Array.from(v)), a);
+  assert.deepEqual(kernel2(a, b).map(v => Array.from(v)), b);
+  assert.deepEqual(kernel3(a, b).map(v => Array.from(v)), cExpected);
+  gpu.destroy();
+}
+
+test('auto', () => {
+  testRewrittenArrays();
+});
+
+test('gpu', () => {
+  testRewrittenArrays('gpu');
+});
+
+(GPU.isWebGLSupported ? test : skip)('webgl', () => {
+  testRewrittenArrays('webgl');
+});
+
+(GPU.isWebGL2Supported ? test : skip)('webgl2', () => {
+  testRewrittenArrays('webgl2');
+});
+
+(GPU.isHeadlessGLSupported ? test : skip)('headlessgl', () => {
+  testRewrittenArrays('headlessgl');
+});
+
+test('cpu', () => {
+  testRewrittenArrays('cpu');
+});