Skip to content

Commit 2e9a8a8

Browse files
committed
Update Chakra.ICU to support ICU 62.1
Note that the default is still ICU 61.1
1 parent 6d96d5b commit 2e9a8a8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

deps/Chakra.ICU/Chakra.ICU.Build.props

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
UCONFIG_NO_REGULAR_EXPRESSIONS=1;
2828
UCONFIG_NO_SERVICE=1;
2929
%(PreprocessorDefinitions)
30-
</PreprocessorDefinitions>
30+
</PreprocessorDefinitions>
3131

3232
<!-- Default ICU Configuration (see source\common\common.vcxproj) -->
3333
<!-- Note that we already configure most of what common.vcxproj handles elsewhere -->
@@ -36,6 +36,9 @@
3636
_CRT_SECURE_NO_DEPRECATE;
3737
%(PreprocessorDefinitions)
3838
</PreprocessorDefinitions>
39+
40+
<!-- Some ICU files use embedded UTF-8 -->
41+
<AdditionalOptions>/utf-8 %(AdditionalOptions)</AdditionalOptions>
3942
</ClCompile>
4043
</ItemDefinitionGroup>
4144
</Project>

deps/Chakra.ICU/Chakra.ICU.i18n.vcxproj

-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@
3131
%(AdditionalIncludeDirectories);
3232
$(IcuSourceDirectory)\common
3333
</AdditionalIncludeDirectories>
34-
35-
<!-- Some ICU files use embedded UTF-8 -->
36-
<AdditionalOptions>/utf-8 %(AdditionalOptions)</AdditionalOptions>
3734
</ClCompile>
3835
<Link Condition="'$(ChakraICU)'=='shared'">
3936
<SubSystem>Console</SubSystem>

0 commit comments

Comments
 (0)