|
1 |
| -### Summary of this Pull Request (PR) 拉取请求的简述 |
| 1 | +### Summary of this Pull Request (PR) 拉取/合并请求的简述 |
2 | 2 |
|
3 |
| -**Add description here.** |
| 3 | +**Add description here.** **请在这里加入描述** |
4 | 4 |
|
5 |
| -### Intent for your PR 拉取请求的目的 |
| 5 | +### Intent for your PR 拉取/合并请求的目的 |
6 | 6 |
|
7 | 7 | Choose one (Mandatory): 必须选择一项
|
8 | 8 |
|
9 |
| -- [ ] This PR is for a code-review and is intended to get feedback 本拉取请求是一个草稿版本 |
10 |
| -- [ ] This PR is mature, and ready to be integrated into the repo 本拉取请求是一个成熟版本 |
| 9 | +- [ ] This PR is for a code-review and is intended to get feedback 本拉取/合并请求是一个草稿版本 |
| 10 | +- [ ] This PR is mature, and ready to be integrated into the repo 本拉取/合并请求是一个成熟版本 |
11 | 11 |
|
12 | 12 | ### Reviewers (Mandatory): 代码审阅者(必须指定)
|
13 |
| -(@<github.com username(s)> Ex: @user1, @user2) |
14 | 13 |
|
| 14 | +(@<github.com username(s)> Ex: @user1, @user2) |
15 | 15 |
|
16 | 16 | ### Code Quality: 代码质量
|
| 17 | + |
17 | 18 | As part of this pull request, I've considered the following:
|
18 |
| -我在这个拉取请求中考虑了: |
19 |
| -- [ ] Style guide is adhered to, including spacing, naming and other style 代码的格式正确 |
20 |
| -- [ ] All redundant code is removed and cleaned up 没有垃圾代码 |
21 |
| -- [ ] All modifications are justified 所有变更均有原因 |
22 |
| -- [ ] I've commented appropriately where code is tricky 难懂代码均被注释 |
23 |
| -- [ ] Code in this PR is of high quality 本拉取请求高质量 |
| 19 | +我在这个拉取/合并请求中已经考虑了: |
| 20 | + |
| 21 | +- [ ] Already check the difference between PR and old code 已经仔细查看过代码改动的对比 |
| 22 | +- [ ] Style guide is adhered to, including spacing, naming and other style 代码风格正确,包括缩进空格,命名及其他风格 |
| 23 | +- [ ] All redundant code is removed and cleaned up 没有垃圾代码,代码尽量精简,不包含`#if 0`代码,不包含已经被注释了的代码 |
| 24 | +- [ ] All modifications are justified and not affect other components or BSP 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP |
| 25 | +- [ ] I've commented appropriately where code is tricky 对难懂代码均提供对应的注释 |
| 26 | +- [ ] Code in this PR is of high quality 本拉取/合并请求代码是高质量的 |
24 | 27 |
|
25 | 28 | ### Testing:代码测试
|
26 | 29 |
|
27 | 30 | I've tested the code using the following test programs (provide list here):
|
28 |
| -我已经在如下用例上跑过测试: |
| 31 | +我已经在如下场合跑过对应的测试: |
29 | 32 |
|
30 | 33 | - [ ] application 1
|
31 | 34 | - [ ] application 2
|
|
0 commit comments