Skip to content

Improve UX for "Copy to" option with success dialog #12486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
priyanshu16095 opened this issue Feb 10, 2025 · 36 comments · Fixed by #12493 or #13071
Closed

Improve UX for "Copy to" option with success dialog #12486

priyanshu16095 opened this issue Feb 10, 2025 · 36 comments · Fixed by #12493 or #13071
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@priyanshu16095
Copy link
Contributor

priyanshu16095 commented Feb 10, 2025

Is your suggestion for improvement related to a problem? Please describe.

Currently, when using the "Copy to" option, there is no confirmation message indicating whether the entry was successfully copied. This can lead to confusion, as users may not be sure if the action was completed.

Describe the solution you'd like

  • Display a confirmation dialog similar to the 'Copy Title' option.
  • The message should confirm that the entry was copied successfully.
  • The message should also indicate whether the cross-reference entry was copied or not.
@subhramit subhramit added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 10, 2025
@MhammedAhmmed
Copy link
Contributor

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 10, 2025
Copy link
Contributor

👋 Hey @MhammedAhmmed, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 11 May 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@MhammedAhmmed
Copy link
Contributor

MhammedAhmmed commented Feb 12, 2025

@priyanshu16095 I found the "Copy Title" option, but I couldn't locate the "Copy To" option. Could you please guide me on where to find it in the JabRef interface?
Thanks for your help!

@priyanshu16095
Copy link
Contributor Author

priyanshu16095 commented Feb 12, 2025

@MhammedAhmmed Yeah, I'm more than happy to help you!

Image

This is the "Copy title" option. When used, it displays a dialog at the bottom, like this:

Image

You need to add this functionality to this option:

Image

For reference, you can check this PR #12374, where this feature was added.
The "Copy title" option is present inside gui directory in CopyMoreAction file.

@MhammedAhmmed
Copy link
Contributor

Thank you so much @priyanshu16095

@feroparea
Copy link

Hi, I’m a student contributing to open source for my university project.
I would like to work on this issue. Could you please assign it to me?
Thank you in advance! 😊

Copy link
Contributor

👋 Hey @feroparea, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@feroparea
Copy link

/assign-me

1 similar comment
@feroparea
Copy link

/assign-me

Copy link
Contributor

👋 Hey @feroparea, this issue is already assigned to @MhammedAhmmed.

Note

⏳ If the issue isn't closed within ** days**, it will be automatically unassigned.
A maintainer can also add you to the list of assignees or swap you with the current assignee.

@feroparea
Copy link

Hi @maintainers,

I noticed that this issue is currently assigned to @MhammedAhmmed.
If they are no longer working on it or if you are open to multiple contributors,
I would be happy to help as part of my university open-source project.

Thank you in advance for your consideration! 😊

@feroparea
Copy link

Hi,
I would like to work on this issue as part of my university open-source project.
Could you please assign it to me? 😊
Thank you!

Copy link
Contributor

👋 Hey @feroparea, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@feroparea
Copy link

/assign-me

@github-project-automation github-project-automation bot moved this from Free to take to Done in Good First Issues Feb 15, 2025
@priyanshu16095
Copy link
Contributor Author

priyanshu16095 commented Feb 15, 2025

@Siedlerchr The PR #12493 does not fix the issue, it only works in the simple case. When the duplicate resolver dialog appears, the notification comes on top of it and even if refused to copy in the resolver, it still says copied.

Image

@Siedlerchr Siedlerchr reopened this Feb 15, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Good First Issues Feb 15, 2025
@Siedlerchr
Copy link
Member

Feel free to create a follow up fix

@subhramit subhramit removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 20, 2025
@koppor koppor moved this from In Progress to Free to take in Good First Issues Feb 20, 2025
@Spkap
Copy link

Spkap commented Feb 22, 2025

/assign-me

@RiddheshRajwadkar
Copy link

I have sent a PR for this issue. May I know what to do next?

@priyanshu16095
Copy link
Contributor Author

It will be reviewed by the maintainers, sometimes it may take longer.

@github-actions github-actions bot removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) 📌 Pinned labels Apr 22, 2025
@koppor koppor moved this from In Progress to Free to take in Good First Issues Apr 22, 2025
@koppor koppor moved this from Free to take to In Progress in Good First Issues Apr 24, 2025
@koppor koppor moved this from In Progress to Free to take in Good First Issues Apr 24, 2025
@luks-santos
Copy link
Contributor

Hey @priyanshu16095 , I think this issue was already fixed in this PR: #12493, wasn't it?

@priyanshu16095
Copy link
Contributor Author

@Siedlerchr The PR #12493 does not fix the issue, it only works in the simple case. When the duplicate resolver dialog appears, the notification comes on top of it and even if refused to copy in the resolver, it still says copied.

Image

Please refer to this comment.

@luks-santos
Copy link
Contributor

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

👋 Hey @luks-santos, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@koppor koppor moved this from Free to take to Assigned in Good First Issues May 5, 2025
@koppor koppor moved this from Assigned to In Progress in Good First Issues May 6, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Good First Issues May 10, 2025
Copy link
Contributor

We think that this issue was fixed. Please head to https://builds.jabref.org/main to download a development build and try it out.

For any feedback, add a comment to the pull request at #13071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment