fix(templates): <=2.10 template additions, falsy url type;

- Added old template blocks for version 2.10 and less.
- Added falsy check on url_type in template helper method.

Author: JVickery-TBS

ckanext/xloader/helpers.py

@@ -38,5 +38,5 @@ def is_resource_supported_by_xloader(res_dict, check_access = True):
     try:
         is_supported_url_type = res_dict.get('url_type') not in toolkit.h.datastore_rw_resource_url_types()
     except AttributeError:
-        is_supported_url_type = (res_dict.get('url_type') == 'upload' or res_dict.get('url_type') == '')
+        is_supported_url_type = (res_dict.get('url_type') == 'upload' or not res_dict.get('url_type'))
     return (is_supported_format or is_datastore_active) and user_has_access and is_supported_url_type

ckanext/xloader/templates/package/resource_read.html

@@ -6,3 +6,10 @@
     <li>{% link_for _('DataStore'), named_route='xloader.resource_data', id=pkg.name, resource_id=res.id, class_='btn btn-light', icon='cloud-upload' %}</li>
   {% endif %}
 {% endblock %}
+
+{% block resource_actions_inner %}
+  {% if h.check_ckan_version(max_version='2.10') and h.is_resource_supported_by_xloader(res) %}
+    <li>{% link_for _('DataStore'), named_route='xloader.resource_data', id=pkg.name, resource_id=res.id, class_='btn btn-light', icon='cloud-upload' %}</li>
+  {% endif %}
+  {{ super() }}
+{% endblock %}

ckanext/xloader/templates/package/snippets/resource_item.html

@@ -6,3 +6,10 @@
     <li>{% link_for _('DataStore'), named_route='xloader.resource_data', id=pkg.name, resource_id=res.id, class_='dropdown-item', icon='cloud-upload' %}</li>
   {% endif %}
 {% endblock %}
+
+{% block resource_item_explore_links %}
+  {% if h.check_ckan_version(max_version='2.10') and h.is_resource_supported_by_xloader(res) %}
+    <li>{% link_for _('DataStore'), named_route='xloader.resource_data', id=pkg.name, resource_id=res.id, class_='dropdown-item', icon='cloud-upload' %}</li>
+  {% endif %}
+  {{ super() }}
+{% endblock %}