fix(engine): validate metadata candidate paths

Author: JSONbored

packages/gittensory-engine/src/miner-goal-lane-fit.ts

@@ -55,8 +55,8 @@ export function computeMinerGoalLaneFit(
   return clamp01(score);
 }
 
-function normalizeCandidatePaths(paths: readonly string[] | undefined): string[] {
-  if (!paths) return [];
+function normalizeCandidatePaths(paths: unknown): string[] {
+  if (!Array.isArray(paths)) return [];
   const normalized: string[] = [];
   for (const path of paths) {
     if (typeof path !== "string") continue;

packages/gittensory-engine/test/miner-goal-lane-fit.test.ts

@@ -95,13 +95,32 @@ test("computeMetadataLaneFit returns 0 when candidatePaths hit blockedPaths", ()
   );
 });
 
-test("computeMetadataLaneFit ignores blank or malformed candidatePaths entries", () => {
-  const spec = { ...DEFAULT_MINER_GOAL_SPEC, preferredLabels: ["bug"] };
+test("computeMetadataLaneFit ignores malformed candidatePaths values", () => {
+  const spec = {
+    ...DEFAULT_MINER_GOAL_SPEC,
+    blockedPaths: ["src/**"],
+    preferredLabels: ["bug"],
+    wantedPaths: ["src/**"],
+  };
   assert.equal(
     computeMetadataLaneFit(
       { labels: ["bug"], candidatePaths: ["", "  ", 42 as unknown as string] },
       spec,
     ),
     1,
   );
+  assert.equal(
+    computeMetadataLaneFit(
+      { labels: ["bug"], candidatePaths: { path: "src/app.ts" } as unknown as string[] },
+      spec,
+    ),
+    1,
+  );
+  assert.equal(
+    computeMetadataLaneFit(
+      { labels: ["bug"], candidatePaths: "src/app.ts" as unknown as string[] },
+      spec,
+    ),
+    1,
+  );
 });

test/unit/miner-goal-lane-fit.test.ts

@@ -43,14 +43,31 @@ describe("computeMetadataLaneFit", () => {
     ).toBe(0);
   });
 
-  it("ignores non-string candidatePaths entries before scoring", () => {
-    const spec = { ...DEFAULT_MINER_GOAL_SPEC, preferredLabels: ["bug"] };
+  it("ignores malformed candidatePaths values before scoring", () => {
+    const spec = {
+      ...DEFAULT_MINER_GOAL_SPEC,
+      blockedPaths: ["src/**"],
+      preferredLabels: ["bug"],
+      wantedPaths: ["src/**"],
+    };
     expect(
       computeMetadataLaneFit(
         { labels: ["bug"], candidatePaths: [42 as unknown as string, ""] },
         spec,
       ),
     ).toBe(1);
+    expect(
+      computeMetadataLaneFit(
+        { labels: ["bug"], candidatePaths: { path: "src/app.ts" } as unknown as string[] },
+        spec,
+      ),
+    ).toBe(1);
+    expect(
+      computeMetadataLaneFit(
+        { labels: ["bug"], candidatePaths: "src/app.ts" as unknown as string[] },
+        spec,
+      ),
+    ).toBe(1);
   });
 });