Skip to content

Commit baf0a41

Browse files
authored
docs(ci): record why the escalation job's setup-node scan finding was dismissed (#10153)
A scanner flagged actions/setup-node in the escalate-persistent-failure job (#10146) as a filesystem-read risk, citing __tests__/authutil.test.ts. That is a test fixture inside setup-node's own repository, not runtime behaviour, and the feature it exercises -- writing an auth token into .npmrc -- only engages when `registry-url` is supplied. It is supplied in the five publish-*.yml workflows and deliberately not here, so the path is inert in this job. The pin is also the same SHA as all 32 other setup-node uses in the repo, including build-boot in this same file, so the job introduced no dependency that was not already present. No behaviour change -- the finding was reviewed and dismissed, and the reason is recorded here so the next scan does not cost another investigation. The note names the condition that would invalidate it (this step gaining registry-url) rather than dismissing the rule outright.
1 parent 453e7af commit baf0a41

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

.github/workflows/selfhost.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,15 @@ jobs:
195195
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
196196
with:
197197
persist-credentials: false
198+
# Needed only for `node --experimental-strip-types` below (the escalation is a .ts script), and pinned to
199+
# the same SHA as the other 32 setup-node uses in this repo -- including build-boot above -- so this job
200+
# adds no dependency that was not already here.
201+
#
202+
# A scanner flagged this as a filesystem-read risk, citing `__tests__/authutil.test.ts` in setup-node's
203+
# own repository. That is a test fixture, not runtime behaviour, and the feature it covers -- writing an
204+
# auth token into .npmrc -- only engages when `registry-url` is supplied. It is supplied in the five
205+
# publish-*.yml workflows and deliberately not here, so that path is inert in this job. Reviewed and
206+
# dismissed rather than silenced; re-check if this step ever gains `registry-url`.
198207
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
199208
with:
200209
node-version-file: .nvmrc

0 commit comments

Comments
 (0)