test(api): align issue-rag unit suites with #10040 schema validation

Update validateIssueRagInput and route rejection expectations so length
bounds live on RetrieveIssueContextInput and empty/malformed bodies map
to invalid_body, matching the discovery schema gate.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: andriypolanski

test/unit/issue-rag-mcp.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, it } from "vitest";
 import { runIssueRagRetrieval, validateIssueRagInput } from "../../src/mcp/issue-rag";
 import { emptyIssueRagTelemetry } from "../../src/review/issue-rag-retrieval";
+import { PREFLIGHT_LIMITS } from "@loopover/contract";
 import { createTestEnv } from "../helpers/d1";
 
 describe("runIssueRagRetrieval (#4293)", () => {
@@ -21,33 +22,40 @@ describe("runIssueRagRetrieval (#4293)", () => {
     });
   });
 
-  it("rejects oversized repos and invalid labels", () => {
-    expect(validateIssueRagInput({ owner: "acme", repo: "r".repeat(101), title: "Add observability context for self-hosted review planning failures" })).toMatchObject({
-      ok: false,
-      reason: "repo_too_long",
-    });
+  it("rejects invalid labels and over-long bodies (length bounds for owner/repo/title live on the schema)", () => {
+    // #10040: repo/title max-length are on RetrieveIssueContextInput; this helper only rejects after trim /
+    // per-label length / body length / topK shape.
     expect(
       validateIssueRagInput({
         owner: "acme",
         repo: "demo",
         title: "Add observability context for self-hosted review planning failures",
-        labels: ["x".repeat(101)],
+        labels: ["x".repeat(PREFLIGHT_LIMITS.labelChars + 1)],
       }),
     ).toMatchObject({ ok: false, reason: "invalid_labels" });
+    expect(
+      validateIssueRagInput({
+        owner: "acme",
+        repo: "demo",
+        title: "Add observability context for self-hosted review planning failures",
+        body: "x".repeat(PREFLIGHT_LIMITS.bodyChars + 1),
+      }),
+    ).toMatchObject({ ok: false, reason: "body_too_long" });
   });
 
   it("covers validation branches for owner/title/body/labels/topK normalization", () => {
     expect(validateIssueRagInput({ owner: "", repo: "demo", title: "Add observability context for self-hosted review planning failures" })).toMatchObject({
       ok: false,
       reason: "owner_and_repo_required",
     });
+    // #10040: over-long title is a schema concern; whitespace-only title is the helper's title_required.
     expect(
       validateIssueRagInput({
         owner: "acme",
         repo: "demo",
-        title: "x".repeat(301),
+        title: "   ",
       }),
-    ).toMatchObject({ ok: false, reason: "title_too_long" });
+    ).toMatchObject({ ok: false, reason: "title_required" });
     expect(
       validateIssueRagInput({
         owner: "acme",

test/unit/routes-issue-rag.test.ts

@@ -61,6 +61,7 @@ describe("issue-rag retrieve route (#4293)", () => {
     const app = createApp();
     const env = createTestEnv();
 
+    // #10040: empty title fails IssueRagRetrieveRequestSchema.min(1) → invalid_body before the hand-rolled pass.
     const invalid = await app.request(
       ISSUE_RAG_PATH,
       {
@@ -71,7 +72,20 @@ describe("issue-rag retrieve route (#4293)", () => {
       env,
     );
     expect(invalid.status).toBe(400);
-    await expect(invalid.json()).resolves.toMatchObject({ status: "invalid_request", reason: "title_required" });
+    await expect(invalid.json()).resolves.toMatchObject({ status: "invalid_request", reason: "invalid_body" });
+
+    // Whitespace-only title clears the schema min(1) then fails validateIssueRagInput's post-trim check.
+    const whitespaceTitle = await app.request(
+      ISSUE_RAG_PATH,
+      {
+        method: "POST",
+        headers: { authorization: `Bearer ${env.LOOPOVER_API_TOKEN}`, "content-type": "application/json" },
+        body: JSON.stringify({ owner: "repo-owner", repo: "owned-repo", title: "   " }),
+      },
+      env,
+    );
+    expect(whitespaceTitle.status).toBe(400);
+    await expect(whitespaceTitle.json()).resolves.toMatchObject({ status: "invalid_request", reason: "title_required" });
 
     const malformed = await app.request(
       ISSUE_RAG_PATH,
@@ -83,7 +97,7 @@ describe("issue-rag retrieve route (#4293)", () => {
       env,
     );
     expect(malformed.status).toBe(400);
-    await expect(malformed.json()).resolves.toMatchObject({ status: "invalid_request", reason: "owner_and_repo_required" });
+    await expect(malformed.json()).resolves.toMatchObject({ status: "invalid_request", reason: "invalid_body" });
   });
 
   it("allows sessions through the path allowlist and scopes repo access", async () => {