mcp: delete the last hand-written tool shapes from the remote server (#9662)

`grep -cE "^const \w+Shape = \{" src/mcp/server.ts` returns **0**.

Four of them were still a registration's `inputSchema` -- `issueRagShape`, `findOpportunitiesShape`,
`localBranchVariantsShape`, `variantsShape` -- agreeing with their contract entries only by history,
with nothing to keep them agreeing. The other fifteen had stopped being registered but survived as the
TYPE of their handler (`z.infer<z.ZodObject<typeof preflightShape>>`), which is the same defect one
step removed: a handler typed off a hand-written shape can drift from the contract the tool actually
registers with, and the compiler is satisfied either way.

Both variant tools took the narrower element type: `ComparePrVariantsInput.variants` was an array of
the STDIO server's `LocalScoreInput` while the remote's own handler expected the wider one, so the
remote accepted variants its registry entry rejected. The element is the union now, with
`StdioComparePrVariantsInput` / `StdioCompareLocalVariantsInput` as the declared narrowings -- the
same treatment their singular siblings got.

Gone with them: `changedFileSchema`, `validationEntrySchema` and `planRepoIssuesMilestoneShape`, which
existed only to build the shapes above; the contract already declares all three.

Author: JSONbored

packages/loopover-contract/src/tools/local-branch.ts

@@ -253,6 +253,10 @@ export const draftPrBodyTool = defineTool({
 });
 
 export const CompareLocalVariantsInput = z.object({
+  variants: z.array(LocalBranchAnalysisInput).min(1).max(10),
+});
+/** What the STDIO server serves: each variant is analysed from the checkout, not from caller-supplied shas. */
+export const StdioCompareLocalVariantsInput = z.object({
   variants: z.array(CurrentBranchInput).min(1).max(10),
 });
 export const compareLocalVariantsTool = defineTool({
@@ -381,6 +385,12 @@ export const getEligibilityPlanTool = defineTool({
 });
 
 export const ComparePrVariantsInput = z.object({
+  // #9662: the same union each variant's SINGULAR tool takes, for the same reason -- the element type was
+  // the stdio server's narrower one, so the remote's own handler accepted variants the registry rejected.
+  variants: z.array(LocalScorePreviewInput).min(1).max(10),
+});
+/** What the STDIO server serves: each variant goes through its local preview, which supplies the rest. */
+export const StdioComparePrVariantsInput = z.object({
   variants: z.array(LocalScoreInput).min(1).max(10),
 });
 export const comparePrVariantsTool = defineTool({

packages/loopover-mcp/bin/loopover-mcp.ts

@@ -90,8 +90,6 @@ import {
   CheckTestEvidenceInput,
   ClearSelftuneOverrideInput,
   ClosePrInput,
-  CompareLocalVariantsInput,
-  ComparePrVariantsInput,
   CreateBranchInput,
   CurrentBranchInput,
   DecidePendingActionInput,
@@ -166,6 +164,8 @@ import {
   ValidateLinkedIssueInput,
   WatchIssuesInput,
   StdioWatchIssuesInput,
+  StdioCompareLocalVariantsInput,
+  StdioComparePrVariantsInput,
   getToolContract,
   projectToolDefinition,
   ListPendingActionsStdioInput,
@@ -1620,13 +1620,14 @@ registerStdioTool(
 
 registerStdioTool(
   "loopover_compare_pr_variants",
-  async ({ variants }: z.infer<typeof ComparePrVariantsInput>) => {
+  async ({ variants }: z.infer<typeof StdioComparePrVariantsInput>) => {
     const roots = await clientWorkspaceRoots();
     const previews = [];
     for (const variant of variants) previews.push(await previewLocalScore(withWorkspaceRoots({ ...variant, targetKey: variant.targetKey ?? `variant:${previews.length + 1}` }, roots)));
     previews.sort((left, right) => Number(right?.remotePreview?.result?.effectiveEstimatedScore ?? right?.remotePreview?.result?.scoreEstimate?.estimatedMergedScore ?? 0) - Number(left?.remotePreview?.result?.effectiveEstimatedScore ?? left?.remotePreview?.result?.scoreEstimate?.estimatedMergedScore ?? 0));
     return toolResult("LoopOver PR variant comparison.", { variants: previews });
   },
+  { input: StdioComparePrVariantsInput },
 );
 
 registerStdioTool(
@@ -1757,7 +1758,7 @@ registerStdioTool(
 
 registerStdioTool(
   "loopover_compare_local_variants",
-  async ({ variants }: z.infer<typeof CompareLocalVariantsInput>) => {
+  async ({ variants }: z.infer<typeof StdioCompareLocalVariantsInput>) => {
     const roots = await clientWorkspaceRoots();
     const analyses = [];
     for (const variant of variants) analyses.push(await analyzeCurrentBranch(withWorkspaceRoots(variant, roots)));
@@ -1776,6 +1777,7 @@ registerStdioTool(
       })),
     });
   },
+  { input: StdioCompareLocalVariantsInput },
 );
 
 registerStdioTool(