types(mcp): finish the option-plumbing sweep, and cover both arms of every fallback (#9824)

The review found `explainReviewRiskCli` reading `options.login` raw. That one was the visible end of a
family -- seven more sites read an option without narrowing it, each reachable by an ordinary typo:

- `analyze-branch --login` and `review-pr --login` sent boolean `true` as the contributor login.
- `login --github-token` with no value took the token branch with `true` as the token, instead of
  falling through to the device flow.
- `Number(options.limit)` on a bare `--limit` is 1, so the flag silently capped an audit at one row
  rather than leaving the server's default in place. Same for `--window-days`.
- `String(options.since)` sent `?since=true`, which the route reads as a cursor.
- `validate-config --file` passed a `!options.file` guard (a bare flag is `true`, which is truthy)
  and then read the manifest from the path "".

Rather than add an eighth copy of each chain, the duplicated ones are now single helpers --
`resolveLogin` (flag, profile session, then two env vars, at 14 call sites), `readOptionalTextFile`
and `issueNumbersOption` -- so there is one place to get it right and one place to test.
`optionalInteger` and `optionalNumber` lose their `any` parameters, which is this issue's subject.

`branchEligibilityFromOptions` restated the route's two enums by hand and dropped anything it did not
recognise. It parses against `branchEligibilityFields` now, exported from the contract for the
purpose: the schema was a pipe, so its members were unreachable through it.

Coverage: the diff is at 100% of lines AND branches in the CLI. Every fallback is exercised from both
sides in `test/unit/mcp-cli-option-resolution.test.ts`, in-process -- the subprocess harness the rest
of the CLI suite uses runs the compiled `dist/`, which v8 cannot instrument, so a path covered only
there reads as uncovered and a regression in one of these arms would land unnoticed.

Author: JSONbored

packages/loopover-contract/src/api-requests.ts

@@ -344,16 +344,28 @@ export const linkedIssueContextSchema = z
   })
   .strict();
 
-export const branchEligibilitySchema = z
+/**
+ * The FIELDS a caller may send, before the route's normalisation runs (#9773).
+ *
+ * Exported separately because `branchEligibilitySchema` is a pipe (it transforms), so its members are not
+ * reachable through it -- and the stdio CLI needs exactly those members to validate `--branch-eligibility`
+ * and `--branch-eligibility-source` against the route's own vocabulary instead of restating both lists.
+ */
+export const branchEligibilityFields = z
   .object({
     status: z.enum(["eligible", "ineligible", "unknown"]),
     source: z.enum(["github_metadata", "local_metadata", "registry", "user_supplied"]).optional(),
     reason: z.string().max(MAX_LOCAL_BRANCH_TEXT_CHARS).optional(),
     checkedAt: z.string().max(MAX_LOCAL_BRANCH_REF_CHARS).optional(),
     stale: z.boolean().optional(),
   })
-  .strict()
-  .transform((value) => ({ ...value, status: value.status === "eligible" ? ("unknown" as const) : value.status, source: "user_supplied" as const }));
+  .strict();
+
+export const branchEligibilitySchema = branchEligibilityFields.transform((value) => ({
+  ...value,
+  status: value.status === "eligible" ? ("unknown" as const) : value.status,
+  source: "user_supplied" as const,
+}));
 
 export const focusManifestInputSchema = z
   .record(z.string(), z.unknown())