random notes

[moonfather1]

this is going to be random, but since you don't have a discord link listed, github issue it is.

first of all it looks like i'll like the mod. i liked bees and i expect i'll like crops more. (btw i'm one of people who play without simulation upgrade).
and i understand this is in early phase.

ok: 1) i have no idea what i'm doing. there is no jei plugin (again, i understand; early phase), no book, and no pondering. i see that you are bringing along Ponder 1.0.61, but either i'm stupid or it doesn't work. maybe it doesn't work without create and i don't use create. yeah, it's the best big industry mod out there, no question about it, but it's kinda overpowered. i use "hopper gadgetry" and i'm happy with it. edit, ok there is pondering but only for one block.

2. mushrooms are weird. they seem to want to grow on vertical sides but they attach to the wrong side. i have an oyster mushroom growing on the side of kadsura crop. not kidding. there is a dirt block on the opposite side of kadsura and maybe mushrooms wanted to attach to the dirt block but they attached to the bush. when i bought first few mushrooms from the farmer i built a small mushroom farm on the village edge and spent a while trying to plant the damn things. i gave up, headed out, right clicked the fence gate and then figured out (yeah they attach to the fence gates if there is a solid block on the other side).

3. some seed stacks don't stack. if both stacks are low/low/none/none (what the user sees), then they should stack. luckily, in 1.21.1+ you can return true for equality even if components serialize differently.

thanks for making this.

[moonfather1]

4. bug: planting and then destroying amaranth/melanga crop duplicates seeds.

[JaisDK]

Hello, thanks for the feedback. I do have a discord, it's linked from the mod page, but having it here is more useful as I won't forget about it.

1. There is JEI integration where it's relevant but no book. One is planned I just haven't had the energy to make it yet. I don't really have any other relevant blocks to put the ponder on.

2. This is again lack of documentation, but the mushrooms are not to be planted (at least not yet). You shove them in a composter and they grow out the side. I'll put a tooltip on them for now so it's not a hidden feature. I don't know why they can grow on fences, that's something to correct.

3. Do you have some documentation on how this is done?

4. Fixed that for next version.

[moonfather1]

3 Do you have some documentation on how this is done?

oh just override equals in your data component class. also hashcode.
that controls whether item in hand moves down and up when component changes, whether two stacks stack together and whether the component should be updated in world save and on client.

You shove them in a composter and they grow out the side.

i like that. it's pretty novel (in minecraft gameplay) and realistic.
please make them reduce composter level from time to time so that they don't just grow on empty composters.

...I don't know why they can grow on fences, that's something to correct.

it's not fences; they can grow on anything, once the "can be placed there" says yes. they can grow on the side of your berry bushes.

[JaisDK]

I don't have a data component class, they're just integer components
https://github.com/JDKDigital/productivefarming/blob/dev-1.21.1/src/main/java/cy/jdkdigital/productivefarming/registry/FarmingDataComponents.java#L19-L22

[moonfather1]

i see the problem. seed from the garden has 11 components in total, seed from the villager farmer has 7.
you need to put zeros into new ones. call component() four times when creating new Item.Properties.

[moonfather1]

related problem:
right clicking mature oregano crop gives me a few oregano items (not seeds) with 6 components.
breaking mature oregano crop gives me a few oregano items (not seeds) with 10 components. these don't stack with those above although same as far as the player should care.

[moonfather1]

i'll go back to numbers for easier tracking:
5) rosemery isn't compostable (seeds are). also oregano.
6) above two seem to have zero (or super tiny) chance of giving new seeds.

[JaisDK]

so breaking the crops that have seeds applies the components to both seed and crop which it shouldn't, harvesting does not apply the traits and you get two different stacks

[JaisDK]

fixing that took care of number 6 as well