addresses code climate fixes

evantk91 · evantk91 · commit c029ce51d32b · 2023-02-15T17:10:42.000-07:00
diff --git a/iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java b/iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java
@@ -26,7 +26,6 @@
 import java.util.Map;
 
 class IterableNotificationHelper {
-    private static final String DEFAULT_CHANNEL_NAME = "iterable channel";
     private static final String NO_BADGE = "_noBadge";
 
     @VisibleForTesting
@@ -459,7 +458,7 @@ private static Uri getSoundUri(Context context, String soundName, String soundUr
             soundId = context.getResources().getIdentifier(soundName, IterableConstants.SOUND_FOLDER_IDENTIFIER, context.getPackageName());
         }
 
-        if (soundId == 0 || soundName == null) {
+        if (soundId == 0) {
             return Settings.System.DEFAULT_NOTIFICATION_URI;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@`
`26`	`26`	`import java.util.Map;`
`27`	`27`
`28`	`28`	`class IterableNotificationHelper {`
`29`		`- private static final String DEFAULT_CHANNEL_NAME = "iterable channel";`
`30`	`29`	`private static final String NO_BADGE = "_noBadge";`
`31`	`30`
`32`	`31`	`@VisibleForTesting`
`@@ -459,7 +458,7 @@ private static Uri getSoundUri(Context context, String soundName, String soundUr`
`459`	`458`	`soundId = context.getResources().getIdentifier(soundName, IterableConstants.SOUND_FOLDER_IDENTIFIER, context.getPackageName());`
`460`	`459`	`}`
`461`	`460`
`462`		`- if (soundId == 0 \|\| soundName == null) {`
	`461`	`+ if (soundId == 0) {`
`463`	`462`	`return Settings.System.DEFAULT_NOTIFICATION_URI;`
`464`	`463`	`}`
`465`	`464`