Add confirmation before turning on the override, using text from Firefox 52 screen sharing

Author: IsaacSchemm

README.md

@@ -6,23 +6,26 @@ adds a toolbar button for toggling the **media.navigator.permission.disabled**
 setting on and off. SeaMonkey does not have a permissions dialog to let the
 user select a camera and microphone (see
 [bug 956854](https://bugzilla.mozilla.org/show_bug.cgi?id=956854)), so
-overriding the permissions dialog is the only way to enable WebRTC support.
+overriding the permissions dialog by turning this setting on is the only way to enable WebRTC support.
 
-Of course, leaving this setting on is *very insecure*, since any web site
-will be able to get access to your microphone and camera! So be sure to only
-turn it on when you need to use WebRTC, and **turn it off** once you have
-your webcam up and running.
+Of course, leaving this setting on is very insecure, since any web site
+that's open will be able to get access to your microphone, camera, and screen! So be sure to only
+turn it on when you need to use WebRTC, and turn it off once you're done with it.
 
 Opening a new browser window will also turn off the permissions dialog
 override, unless you disable this behavior in the extension preferences.
 
+NOTE: your first camera/screen/etc. will be chosen automatically. If you
+need to select a particular camera, mic, screen, or window to share, you'll
+have to use another web browser (like Firefox.)
+
 Releases
 --------
 
 Check the GitHub [releases section](https://github.com/IsaacSchemm/webrtc-permissions-ui-toggle/releases)
 for an XPI file that you can install.
 
-This extension might also work in Firefox (tested with Firefox 52), but since
-it's unsigned, you'll need to use the Developer Edition or a non-branded
-build. However, since Firefox already has a WebRTC permissions dialog, this
-extension is **not recommended** for Firefox and should not be necessary.
+This extension might also work in Firefox, but you'll need to add Firefox to
+the install.rdf and build the extension yourself. Since Firefox already has a
+WebRTC permissions dialog, this extension is not recommended for Firefox and
+should not be necessary.

chrome/button.js

@@ -19,11 +19,11 @@ this.addEventListener("load", function () {
 				if (newValue) {
 					toolbarbutton.label = toolbarbutton.tooltipText = "WebRTC Auto (On)";
 					toolbarbutton.classList.add("setting-true");
-					message = "Automatic WebRTC connection has been turned on (permissions dialog overridden).\nYou might need to refresh the current page.";
+					message = "Automatic WebRTC connection has been turned on. Make sure to turn it off when you're done!\nYou might need to refresh the current page.";
 				} else {
 					toolbarbutton.label = toolbarbutton.tooltipText = "WebRTC Auto (Off)";
 					toolbarbutton.classList.remove("setting-true");
-					message = "Automatic WebRTC connection has been turned off (permissions dialog re-enabled).";
+					message = "Automatic WebRTC connection has been turned off.";
 				}
 
 				var type = Components.classes["@mozilla.org/preferences-service;1"]
@@ -81,6 +81,12 @@ this.addEventListener("unload", function () {
 WebRTCPermissionsButtons = {
 	TogglePermissionsUI: function (toolbarbutton) {
 		var actualValue = prefs.getBoolPref("disabled");
-		prefs.setBoolPref("disabled", !actualValue);
+		if (actualValue) {
+			prefs.setBoolPref("disabled", false);
+		} else if (confirm(`Only use this feature with sites you trust. Sharing can allow deceptive sites to browse as you and steal your private data.
+Are you sure you want to share your camera, microphone, and screen with all open web sites?
+`)) {
+			prefs.setBoolPref("disabled", true);
+		}
 	}
 }

install.rdf

@@ -11,22 +11,13 @@
     em:creator="Isaac Schemm"
 
     em:id="[email protected]"
-    em:version="1.0"
+    em:version="1.0.1"
     em:homepageURL="https://github.com/IsaacSchemm/webrtc-permissions-ui-toggle"
 
     em:iconURL="chrome://webrtc-permissions-ui-toggle/content/icon.png"
 	em:optionsURL="chrome://webrtc-permissions-ui-toggle/content/options.xul"
 	em:optionsType="2" >
 
-    <em:targetApplication>
-	  <!-- Firefox -->
-	  <Description>
-		<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
-		<em:minVersion>49.0</em:minVersion>
-		<em:maxVersion>*</em:maxVersion>
-	  </Description>
-	</em:targetApplication>
-
     <em:targetApplication>
 	  <!-- SeaMonkey -->
 	  <Description>
@@ -36,12 +27,6 @@
 	  </Description>
 	</em:targetApplication>
 
-    <em:file>
-      <Description
-        about="urn:mozilla:extension:webrtc-permissions-ui-toggle"
-        em:package="content/webrtc-permissions-ui-toggle/" />
-    </em:file>
-
   </Description>
 
 </RDF>