Skip to content

Commit 54c40e0

Browse files
committed
Properly reset WebRTC disabled status when browser is closed
1 parent 892864d commit 54c40e0

File tree

2 files changed

+22
-10
lines changed

2 files changed

+22
-10
lines changed

components/WebRTCToggle.js

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,26 @@ Components.utils.import("resource://gre/modules/Console.jsm");
1313
AddonManager.addAddonListener({
1414
onUninstalling: function(addon) {
1515
if (addon.id == "[email protected]") {
16-
Components.classes["@mozilla.org/preferences-service;1"]
17-
.getService(Components.interfaces.nsIPrefService)
18-
.getBranch("media.navigator.permission.")
16+
var svc = Components.classes["@mozilla.org/preferences-service;1"]
17+
.getService(Components.interfaces.nsIPrefService);
18+
svc.getBranch("media.navigator.permission.")
1919
.setBoolPref("disabled", false);
20+
svc.getBranch("media.navigator.")
21+
.clearUserPref("enabled");
22+
svc.getBranch("media.peerconnection.")
23+
.clearUserPref("enabled");
2024
}
2125
},
2226
onDisabling: function(addon) {
2327
if (addon.id == "[email protected]") {
24-
Components.classes["@mozilla.org/preferences-service;1"]
25-
.getService(Components.interfaces.nsIPrefService)
26-
.getBranch("media.navigator.permission.")
28+
var svc = Components.classes["@mozilla.org/preferences-service;1"]
29+
.getService(Components.interfaces.nsIPrefService);
30+
svc.getBranch("media.navigator.permission.")
2731
.setBoolPref("disabled", false);
32+
svc.getBranch("media.navigator.")
33+
.clearUserPref("enabled");
34+
svc.getBranch("media.peerconnection.")
35+
.clearUserPref("enabled");
2836
}
2937
}
3038
});
@@ -81,10 +89,14 @@ WebRTCToggle.prototype = {
8189
// Turn the override off when closing the application,
8290
// regardless of whether or not the add-on is going to be
8391
// uninstalled.
84-
Components.classes["@mozilla.org/preferences-service;1"]
85-
.getService(Components.interfaces.nsIPrefService)
86-
.getBranch("media.navigator.permission.")
92+
var svc = Components.classes["@mozilla.org/preferences-service;1"]
93+
.getService(Components.interfaces.nsIPrefService);
94+
svc.getBranch("media.navigator.permission.")
8795
.setBoolPref("disabled", false);
96+
svc.getBranch("media.navigator.")
97+
.clearUserPref("enabled");
98+
svc.getBranch("media.peerconnection.")
99+
.clearUserPref("enabled");
88100
break;
89101
case "nsPref:changed":
90102
var strings = Components.classes["@mozilla.org/intl/stringbundle;1"]

install.rdf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
em:creator="Isaac Schemm"
1212

1313
14-
em:version="1.3.1"
14+
em:version="1.3.2"
1515
em:homepageURL="https://github.com/IsaacSchemm/webrtc-permissions-ui-toggle"
1616

1717
em:iconURL="chrome://webrtc-permissions-ui-toggle/content/icon.png"

0 commit comments

Comments
 (0)