Skip to content

Commit dd7fdb0

Browse files
committed
fix: remove useless code; fix typo
1 parent 787700e commit dd7fdb0

File tree

6 files changed

+6
-11
lines changed

6 files changed

+6
-11
lines changed

app/audio/src/main/cpp/audio/audio.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11

22
#include <jni.h>
33
#include <napi/napi.h>
4+
45
#include <string>
56

67
#include "AudioEngine.hpp"
7-
#include "logger.hpp"
8-
#include "preload_script.hpp"
9-
108
#include "JSAudioBuffer.hpp"
119
#include "JSAudioBufferSourceNode.hpp"
1210
#include "JSAudioContext.hpp"
@@ -20,6 +18,7 @@
2018
#include "JSOfflineAudioCompletionEvent.hpp"
2119
#include "JSOfflineAudioContext.hpp"
2220
#include "JSOscillatorNode.hpp"
21+
#include "preload_script.hpp"
2322

2423
static Napi::Object Init(Napi::Env env, Napi::Object exports) {
2524
js_audio::JSOfflineAudioCompletionEvent::Init(env, exports);

app/audio/src/main/cpp/cpp_layer/AudioEngine/AudioEngine.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ class AudioEngine {
1919
~AudioEngine();
2020

2121
static std::weak_ptr<AudioEngine> Get();
22-
static void SetPlayerSampleRate(const uint32_t &sample_rate);
23-
static void SetPlayerSamplesPerBuffer(const uint32_t &samples_per_buffer);
2422

2523
void Start();
2624
void Pause();

app/audio/src/main/java/com/example/audio/AudioHandler.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.example.audio
22

33
import android.content.Context
4-
import android.media.AudioFormat
54
import android.media.AudioManager
6-
import android.media.AudioTrack
75
import android.util.Log
86
import com.example.node_env.NodeModuleHandler
97

app/dependency/cpp/node/include/napi_ih/napi_ih_inl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,8 @@ inline void Registration::ProcessClassMetaInfo(
435435
}
436436
ClassMetaInfo *parent = info->parent;
437437
if (parent != nullptr) {
438-
ProcessClassMetaInfo(env, exports, parent, ctor_table);
439438
// TODO: this can be optimized mem space by while loop
439+
ProcessClassMetaInfo(env, exports, parent, ctor_table);
440440
info->descriptors.reserve(info->descriptors.size() +
441441
parent->descriptors.size());
442442
info->descriptors.insert(info->descriptors.end(),

app/node_env/src/main/cpp/node_env/NodeEnv.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ int NodeEnv::PrepareNodeEnv(std::vector<std::string> &argv) {
205205
v8::V8::InitializePlatform(instance_->platform_.get());
206206
v8::V8::Initialize();
207207

208-
node::IsolateData *isolate_data = CreateNodeIsoateData();
208+
node::IsolateData *isolate_data = CreateNodeIsolateData();
209209
if (isolate_data == nullptr) {
210210
LOGE("Create node isolate data failed!\n");
211211
return NI_NODE_CREATE_ISOLATE_DATA_FAILED;
@@ -226,7 +226,7 @@ void NodeEnv::Clear() {
226226
}
227227
}
228228

229-
node::IsolateData *NodeEnv::CreateNodeIsoateData() {
229+
node::IsolateData *NodeEnv::CreateNodeIsolateData() {
230230
uv_loop_t &loop = instance_->loop_;
231231
node::MultiIsolatePlatform *platform = instance_->platform_.get();
232232

app/node_env/src/main/cpp/node_env/NodeEnv.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class NodeEnv {
3636
static int PrepareUvloop(const std::vector<std::string> &vec_argv);
3737
static int PrepareNodeEnv(std::vector<std::string> &args);
3838
static void LoadInternalModules();
39-
static node::IsolateData *CreateNodeIsoateData();
39+
static node::IsolateData *CreateNodeIsolateData();
4040
static node::Environment *
4141
CreateNodeEnv(const std::vector<std::string> &argv,
4242
const std::vector<std::string> &exec_argv);

0 commit comments

Comments
 (0)