CDDL with typeclasses: mary, alonzo, babbage #5443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Export `Era` from `Cardano.Ledger.Huddle` so that later eras do not need to depend on core directly; they can just import the previous era. * Add smart-constructors for scripts-related rules and reorganise them.
Repeat the same additions as core and shelley for mary. Update changelogs for shelley and allegra to mention `generate-cddl`.
Repeat the same additions as core, shelley, allegra and mary.
aniketd
force-pushed
the
aniketd/cddl-typeclass-mary
branch
from
ae10611 to
3920e01
Compare
Repeat the same additions as core, shelley, allegra, mary and alonzo.
aniketd
force-pushed
the
aniketd/cddl-typeclass-mary
branch
from
3920e01 to
3e363b1
Compare
11 tasks
lehins
approved these changes
Nov 26, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Very, very nice!
I really like how this new approach to using Huddle is coming along.
Comment on lines
+50
to
+51
| instance HuddleRule "major_protocol_version" MaryEra where | ||
| huddleRule _ = "major_protocol_version" =:= (0 :: Integer) ... (5 :: Integer) |
Collaborator
There was a problem hiding this comment.
I think it would be safe to create an instance for all eras like this in cardano-ledger-core, but please confirm that it is indeed the case. If it is not, then we'll need to figure out later how to make it be the case, since that should always be true for all eras, otherwise it would be impossible to transition out of the era.
Suggested change
| instance HuddleRule "major_protocol_version" MaryEra where | |
| huddleRule _ = "major_protocol_version" =:= (0 :: Integer) ... (5 :: Integer) | |
| instance Era era => HuddleRule "major_protocol_version" era where | |
| huddleRule _ = "major_protocol_version" =:= (0 :: Integer) ... lastSupportedEraVersion | |
| where | |
| lastSupportedEraVersion = | |
| getVersion $ errorFail (succVersion (eraProtVerHigh @era)) :: Integer) |
| , transaction_witness_sets : [* transaction_witness_set] | ||
| , auxiliary_data_set : {* transaction_index => auxiliary_data} | ||
| , invalid_transactions : [* transaction_index] | ||
| , invalid_transactions : [* transaction_index] ; new |
Collaborator
There was a problem hiding this comment.
This isn't new in Babbage era
Comment on lines
+295
to
+296
| , "block_body_size" ==> VUInt //- "merkle triple root" | ||
| , "block_body_hash" ==> huddleRule @"hash32" p |
Collaborator
There was a problem hiding this comment.
I believe that comment was intended for the block body hash, instead of size
Suggested change
| , "block_body_size" ==> VUInt //- "merkle triple root" | |
| , "block_body_hash" ==> huddleRule @"hash32" p | |
| , "block_body_size" ==> VUInt | |
| , "block_body_hash" ==> huddleRule @"hash32" p //- "merkle triple root" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New libraries named
cddlfor Mary through Babbage to implement typeclass-based cuddle definitions to generate .cddl files from.Follow-up PRs should implement for Conway.
This is the second phase in our efforts to address #5194
NOTE
codegen on CI is expected to FAIL, and its diff is important to know exactly what has changed in the new implementation.
Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).