Apply suggestions from code review

Co-authored-by: Alexey Kuleshevich <[email protected]>

Author: Lucsanszky

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/DelegSpec.hs

@@ -693,7 +693,7 @@ spec = do
         accountState <- expectJust $ lookupAccountState cred accounts
         expectNothingExpr (accountState ^. stakePoolDelegationAccountStateL)
 
-    expectDelegatedVote :: Credential 'Staking -> DRep -> ImpTestM era ()
+    expectDelegatedVote :: HasCallStack => Credential 'Staking -> DRep -> ImpTestM era ()
     expectDelegatedVote cred drep = do
       accounts <- getsNES $ nesEsL . esLStateL . lsCertStateL . certDStateL . accountsL
       dreps <- getsNES $ nesEsL . epochStateRegDrepL

eras/dijkstra/src/Cardano/Ledger/Dijkstra/Rules/Cert.hs

@@ -47,7 +47,6 @@ instance InjectRuleFailure "CERT" ConwayGovCertPredFailure DijkstraEra where
   injectFailure = GovCertFailure
 
 instance
-  forall era.
   ( Era era
   , State (EraRule "DELEG" era) ~ CertState era
   , State (EraRule "POOL" era) ~ PState era

eras/dijkstra/src/Cardano/Ledger/Dijkstra/TxCert.hs

@@ -92,6 +92,16 @@ data DijkstraDelegCert
 
 instance EncCBOR DijkstraDelegCert where
   encCBOR = \case
+    DijkstraRegCert cred deposit ->
+      encodeListLen 3
+        <> encodeWord8 7
+        <> encCBOR cred
+        <> encCBOR deposit
+    DijkstraUnRegCert cred deposit ->
+      encodeListLen 3
+        <> encodeWord8 8
+        <> encCBOR cred
+        <> encCBOR deposit
     DijkstraDelegCert cred (DelegStake poolId) -> encodeShelleyDelegCert $ ShelleyDelegCert cred poolId
     DijkstraDelegCert cred (DelegVote drep) ->
       encodeListLen 3
@@ -104,16 +114,6 @@ instance EncCBOR DijkstraDelegCert where
         <> encCBOR cred
         <> encCBOR poolId
         <> encCBOR dRep
-    DijkstraRegCert cred deposit ->
-      encodeListLen 3
-        <> encodeWord8 7
-        <> encCBOR cred
-        <> encCBOR deposit
-    DijkstraUnRegCert cred deposit ->
-      encodeListLen 3
-        <> encodeWord8 8
-        <> encCBOR cred
-        <> encCBOR deposit
     DijkstraRegDelegCert cred (DelegStake poolId) deposit ->
       encodeListLen 4
         <> encodeWord8 11