Skip to content

Commit 93ccb91

Browse files
Revert gh-2579 with skipping batched cholesky tests on win ARL and MTL (#2582)
This PR suggest removing the temporary slip batched Cholesky tests that were added in #2579. With driver update on CI ARL machines the issue was solved.
1 parent 017d192 commit 93ccb91

File tree

8 files changed

+1
-25
lines changed

8 files changed

+1
-25
lines changed

dpnp/tests/test_bitwise.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import dpnp
66

77
from .helper import (
8-
assert_dtype_allclose,
98
get_abs_array,
109
get_integer_dtypes,
1110
numpy_version,

dpnp/tests/test_indexing.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
get_array,
2525
get_integer_dtypes,
2626
has_support_aspect64,
27-
is_win_platform,
2827
numpy_version,
2928
)
3029
from .third_party.cupy import testing

dpnp/tests/test_linalg.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
get_float_complex_dtypes,
2424
get_integer_float_dtypes,
2525
has_support_aspect64,
26-
is_arl_or_mtl,
27-
is_win_platform,
2826
numpy_version,
2927
)
3028
from .third_party.cupy import testing
@@ -110,8 +108,6 @@ def test_usm_ndarray_linalg_batch(func, gen_kwargs, func_kwargs):
110108
)
111109
for _ in range(2)
112110
]
113-
elif func == "cholesky" and is_win_platform() and is_arl_or_mtl():
114-
pytest.skip("SAT-8206")
115111
else:
116112
dpt_args = [
117113
dpt.asarray(generate_random_numpy_array(shape, **gen_kwargs))
@@ -161,8 +157,6 @@ class TestCholesky:
161157
def test_cholesky(self, array, dtype):
162158
a = numpy.array(array, dtype=dtype)
163159
ia = dpnp.array(a)
164-
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
165-
pytest.skip("SAT-8206")
166160
result = dpnp.linalg.cholesky(ia)
167161
expected = numpy.linalg.cholesky(a)
168162
assert_dtype_allclose(result, expected)
@@ -182,8 +176,6 @@ def test_cholesky(self, array, dtype):
182176
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
183177
def test_cholesky_upper(self, array, dtype):
184178
ia = dpnp.array(array, dtype=dtype)
185-
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
186-
pytest.skip("SAT-8206")
187179
result = dpnp.linalg.cholesky(ia, upper=True)
188180

189181
if ia.ndim > 2:
@@ -226,8 +218,6 @@ def test_cholesky_upper(self, array, dtype):
226218
def test_cholesky_upper_numpy(self, array, dtype):
227219
a = numpy.array(array, dtype=dtype)
228220
ia = dpnp.array(a)
229-
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
230-
pytest.skip("SAT-8206")
231221
result = dpnp.linalg.cholesky(ia, upper=True)
232222
expected = numpy.linalg.cholesky(a, upper=True)
233223
assert_dtype_allclose(result, expected)

dpnp/tests/test_random_state.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import numpy
55
import pytest
66
from numpy.testing import (
7-
assert_allclose,
87
assert_array_almost_equal,
98
assert_array_equal,
109
assert_equal,

dpnp/tests/test_sycl_queue.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
from .helper import (
1717
generate_random_numpy_array,
1818
get_all_dtypes,
19-
is_arl_or_mtl,
2019
is_win_platform,
2120
)
2221

@@ -1516,8 +1515,6 @@ def test_cholesky(self, data, is_empty, device):
15161515
else:
15171516
dtype = dpnp.default_float_type(device)
15181517
x = dpnp.array(data, dtype=dtype, device=device)
1519-
if x.ndim > 2 and is_win_platform() and is_arl_or_mtl():
1520-
pytest.skip("SAT-8206")
15211518

15221519
result = dpnp.linalg.cholesky(x)
15231520
assert_sycl_queue_equal(result.sycl_queue, x.sycl_queue)

dpnp/tests/test_usm_type.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import dpnp
1111
from dpnp.dpnp_utils import get_usm_allocations
1212

13-
from .helper import generate_random_numpy_array, is_arl_or_mtl, is_win_platform
13+
from .helper import generate_random_numpy_array
1414

1515
list_of_usm_types = ["device", "shared", "host"]
1616

@@ -1366,8 +1366,6 @@ def test_cholesky(self, data, is_empty, usm_type):
13661366
x = dpnp.empty(data, dtype=dtype, usm_type=usm_type)
13671367
else:
13681368
x = dpnp.array(data, dtype=dtype, usm_type=usm_type)
1369-
if x.ndim > 2 and is_win_platform() and is_arl_or_mtl():
1370-
pytest.skip("SAT-8206")
13711369

13721370
result = dpnp.linalg.cholesky(x)
13731371
assert x.usm_type == result.usm_type

dpnp/tests/test_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import dpctl
21
import dpctl.tensor as dpt
32
import numpy
43
import pytest

dpnp/tests/third_party/cupy/linalg_tests/test_decomposition.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
import dpnp as cupy
77
from dpnp.tests.helper import (
88
has_support_aspect64,
9-
is_arl_or_mtl,
109
is_cpu_device,
11-
is_win_platform,
1210
)
1311
from dpnp.tests.third_party.cupy import testing
1412
from dpnp.tests.third_party.cupy.testing import _condition
@@ -84,9 +82,6 @@ def test_decomposition(self, dtype):
8482
# np.linalg.cholesky only uses a lower triangle of an array
8583
self.check_L(numpy.array([[1, 2], [1, 9]], dtype))
8684

87-
@pytest.mark.skipif(
88-
is_win_platform() and is_arl_or_mtl(), reason="SAT-8206"
89-
)
9085
@testing.for_dtypes(
9186
[
9287
numpy.int32,

0 commit comments

Comments
 (0)