Skip to content

Commit 0aa5321

Browse files
ndgrigorianndgrigorian
committed
Remove unnecessary comments about std::disjunction throughout project
1 parent ab068f5 commit 0aa5321

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+124
-265
lines changed

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/abs.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ using AbsContigFunctor =
102102

103103
template <typename T> struct AbsOutputType
104104
{
105-
using value_type = typename std::disjunction< // disjunction is C++17
106-
// feature, supported by DPC++
105+
using value_type = typename std::disjunction<
107106
td_ns::TypeMapResultEntry<T, bool>,
108107
td_ns::TypeMapResultEntry<T, std::uint8_t>,
109108
td_ns::TypeMapResultEntry<T, std::uint16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/acos.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,7 @@ using AcosStridedFunctor = elementwise_common::
145145

146146
template <typename T> struct AcosOutputType
147147
{
148-
using value_type = typename std::disjunction< // disjunction is C++17
149-
// feature, supported by DPC++
148+
using value_type = typename std::disjunction<
150149
td_ns::TypeMapResultEntry<T, sycl::half>,
151150
td_ns::TypeMapResultEntry<T, float>,
152151
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/acosh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,7 @@ using AcoshStridedFunctor = elementwise_common::
172172

173173
template <typename T> struct AcoshOutputType
174174
{
175-
using value_type = typename std::disjunction< // disjunction is C++17
176-
// feature, supported by DPC++
175+
using value_type = typename std::disjunction<
177176
td_ns::TypeMapResultEntry<T, sycl::half>,
178177
td_ns::TypeMapResultEntry<T, float>,
179178
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/add.hpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,7 @@ using AddStridedFunctor =
132132

133133
template <typename T1, typename T2> struct AddOutputType
134134
{
135-
using value_type = typename std::disjunction< // disjunction is C++17
136-
// feature, supported by DPC++
135+
using value_type = typename std::disjunction<
137136
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
138137
td_ns::BinaryTypeMapResultEntry<T1,
139138
std::uint8_t,
@@ -442,10 +441,7 @@ class add_inplace_contig_kernel;
442441
template <typename argTy, typename resTy> struct AddInplaceTypePairSupport
443442
{
444443
/* value if true a kernel for <argTy, resTy> must be instantiated */
445-
static constexpr bool is_defined = std::disjunction< // disjunction is
446-
// C++17 feature,
447-
// supported by
448-
// DPC++ input bool
444+
static constexpr bool is_defined = std::disjunction<
449445
td_ns::TypePairDefinedEntry<argTy, bool, resTy, bool>,
450446
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
451447
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ using AngleStridedFunctor = elementwise_common::
9191

9292
template <typename T> struct AngleOutputType
9393
{
94-
using value_type = typename std::disjunction< // disjunction is C++17
95-
// feature, supported by DPC++
94+
using value_type = typename std::disjunction<
9695
td_ns::TypeMapResultEntry<T, std::complex<float>, float>,
9796
td_ns::TypeMapResultEntry<T, std::complex<double>, double>,
9897
td_ns::DefaultResultEntry<void>>::result_type;

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/asin.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ using AsinStridedFunctor = elementwise_common::
165165

166166
template <typename T> struct AsinOutputType
167167
{
168-
using value_type = typename std::disjunction< // disjunction is C++17
169-
// feature, supported by DPC++
168+
using value_type = typename std::disjunction<
170169
td_ns::TypeMapResultEntry<T, sycl::half>,
171170
td_ns::TypeMapResultEntry<T, float>,
172171
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/asinh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ using AsinhStridedFunctor = elementwise_common::
148148

149149
template <typename T> struct AsinhOutputType
150150
{
151-
using value_type = typename std::disjunction< // disjunction is C++17
152-
// feature, supported by DPC++
151+
using value_type = typename std::disjunction<
153152
td_ns::TypeMapResultEntry<T, sycl::half>,
154153
td_ns::TypeMapResultEntry<T, float>,
155154
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atan.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,7 @@ using AtanStridedFunctor = elementwise_common::
155155

156156
template <typename T> struct AtanOutputType
157157
{
158-
using value_type = typename std::disjunction< // disjunction is C++17
159-
// feature, supported by DPC++
158+
using value_type = typename std::disjunction<
160159
td_ns::TypeMapResultEntry<T, sycl::half>,
161160
td_ns::TypeMapResultEntry<T, float>,
162161
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atan2.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ using Atan2StridedFunctor =
9090

9191
template <typename T1, typename T2> struct Atan2OutputType
9292
{
93-
using value_type = typename std::disjunction< // disjunction is C++17
94-
// feature, supported by DPC++
93+
using value_type = typename std::disjunction<
9594
td_ns::BinaryTypeMapResultEntry<T1,
9695
sycl::half,
9796
T2,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atanh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ using AtanhStridedFunctor = elementwise_common::
149149

150150
template <typename T> struct AtanhOutputType
151151
{
152-
using value_type = typename std::disjunction< // disjunction is C++17
153-
// feature, supported by DPC++
152+
using value_type = typename std::disjunction<
154153
td_ns::TypeMapResultEntry<T, sycl::half>,
155154
td_ns::TypeMapResultEntry<T, float>,
156155
td_ns::TypeMapResultEntry<T, double>,

0 commit comments

Comments
 (0)