Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes for group membership expiration #122

Merged
merged 5 commits into from
Feb 10, 2025
Merged

UI changes for group membership expiration #122

merged 5 commits into from
Feb 10, 2025

Conversation

jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Feb 7, 2025

Description

Read a chosen membership expiration from the user_search.html invite form. Also display expiration in the group view.

Change the form to use a date, not a datetime -- seems silly to chose the minute of expiration.

Some light JS was necessary to enforce minimum today's date, and maximum some way into the future: currently 5 years. Can maybe be a setting passed into the template?

Fix a double quite typo: <form action="{% url 'imperial_coldfront_plugin:send_group_invite' %}" method="post"">.

Fixes #84

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@jamesturner246 jamesturner246 marked this pull request as ready for review February 7, 2025 15:13
Copy link
Collaborator

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @jamesturner246

@cc-a cc-a merged commit a47d6a6 into main Feb 10, 2025
4 checks passed
@cc-a cc-a deleted the grp_expire_ui branch February 10, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupMembership expiry UI changes
2 participants