fix: lint config; fix: ts & lint errors

IdenticalSpring · Sep 14, 2022 · 2d99bc1 · 2d99bc1
1 parent 235555e
commit 2d99bc1
Show file tree

Hide file tree

Showing 22 changed files with 226 additions and 40 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -0,0 +1,6 @@
+module.exports = {
+  extends: ["next/core-web-vitals", "eslint-config-prettier", 'eslint:recommended', 'plugin:@typescript-eslint/recommended'],
+  parser: '@typescript-eslint/parser',
+  plugins: ['@typescript-eslint'],
+  root: true,
+};
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/components/AsideMenu.tsx b/components/AsideMenu.tsx
@@ -7,7 +7,7 @@ type Props = {
   menu: MenuAsideItem[]
   isAsideMobileExpanded: boolean
   isAsideLgActive: boolean
-  onAsideLgClose: Function
+  onAsideLgClose: () => void
 }
 
 export default function AsideMenu({

diff --git a/components/AsideMenuLayer.tsx b/components/AsideMenuLayer.tsx
@@ -9,7 +9,7 @@ import { useAppSelector } from '../src/stores/hooks'
 type Props = {
   menu: MenuAsideItem[]
   className?: string
-  onAsideLgCloseClick: Function
+  onAsideLgCloseClick: () => void
 }
 
 export default function AsideMenuLayer({ menu, className = '', ...props }: Props) {

diff --git a/components/BaseButton.tsx b/components/BaseButton.tsx
@@ -20,7 +20,7 @@ type Props = {
   disabled?: boolean
   roundedFull?: boolean
   isGrouped?: boolean
-  onClick?: Function
+  onClick?: (e: React.MouseEvent) => void
 }
 
 export default function BaseButton({

diff --git a/components/BaseButtons.tsx b/components/BaseButtons.tsx
@@ -1,4 +1,4 @@
-import React, { Children, cloneElement, ReactNode } from 'react'
+import React, { ReactNode } from 'react'
 
 type Props = {
   type?: string

diff --git a/components/CardBox.tsx b/components/CardBox.tsx
@@ -13,7 +13,7 @@ type Props = {
   isModal?: boolean
   children: ReactNode
   footer?: ReactNode
-  onClick?: Function
+  onClick?: (e: React.MouseEvent) => void
 }
 
 export default function CardBox({

diff --git a/components/CardBoxClient.tsx b/components/CardBoxClient.tsx
@@ -1,6 +1,6 @@
 import { mdiTrendingDown, mdiTrendingNeutral, mdiTrendingUp } from '@mdi/js'
 import React from 'react'
-import { Client, ColorKey } from '../interfaces'
+import { Client } from '../interfaces'
 import BaseLevel from './BaseLevel'
 import CardBox from './CardBox'
 import PillTag from './PillTag'

diff --git a/components/CardBoxTransaction.tsx b/components/CardBoxTransaction.tsx
@@ -1,6 +1,6 @@
 import { mdiCashMinus, mdiCashPlus, mdiCreditCard, mdiReceipt } from '@mdi/js'
 import React from 'react'
-import { ColorKey, Transaction } from '../interfaces'
+import { Transaction } from '../interfaces'
 import BaseLevel from './BaseLevel'
 import CardBox from './CardBox'
 import IconRounded from './IconRounded'

diff --git a/components/CardBoxWIdget.tsx → components/CardBoxWidget.tsx b/components/CardBoxWIdget.tsx → components/CardBoxWidget.tsx
@@ -6,7 +6,6 @@ import BaseButton from './BaseButton'
 import BaseIcon from './BaseIcon'
 import BaseLevel from './BaseLevel'
 import CardBox from './CardBox'
-import NumberDynamic from './NumberDynamic'
 import PillTagTrend from './PillTagTrend'
 
 type Props = {

diff --git a/components/NavBar.tsx b/components/NavBar.tsx
@@ -15,9 +15,7 @@ type Props = {
 export default function NavBar({ menu, className = '', children }: Props) {
   const [isMenuNavBarActive, setIsMenuNavBarActive] = useState(false)
 
-  const handleMenuNavBarToggleClick = (e: MouseEvent) => {
-    e.preventDefault()
-
+  const handleMenuNavBarToggleClick = () => {
     setIsMenuNavBarActive(!isMenuNavBarActive)
   }
 

diff --git a/components/NavBarItem.tsx b/components/NavBarItem.tsx
@@ -38,7 +38,7 @@ export default function NavBarItem({ item }: Props) {
 
   const itemLabel = item.isCurrentUser ? userName : item.label
 
-  const handleMenuClick = (e: React.MouseEvent) => {
+  const handleMenuClick = () => {
     if (item.menu) {
       setIsDropdownActive(!isDropdownActive)
     }

diff --git a/components/NavBarItemPlain.tsx b/components/NavBarItemPlain.tsx
@@ -5,7 +5,7 @@ type Props = {
   display?: string
   useMargin?: boolean
   children: ReactNode
-  onClick?: Function
+  onClick?: (e: React.MouseEvent) => void
 }
 
 export default function NavBarItemPlain({
@@ -22,14 +22,8 @@ export default function NavBarItemPlain({
     useMargin ? 'my-2 mx-3' : 'py-2 px-3'
   }`
 
-  const handleClick = (e: React.MouseEvent) => {
-    if (onClick) {
-      onClick(e)
-    }
-  }
-
   return (
-    <div className={`${classBase} ${classAddon}`} onClick={handleClick}>
+    <div className={`${classBase} ${classAddon}`} onClick={onClick}>
       {children}
     </div>
   )

diff --git a/components/OverlayLayer.tsx b/components/OverlayLayer.tsx
@@ -5,7 +5,7 @@ type Props = {
   zIndex?: string
   type?: string
   children?: ReactNode
-  onClick: Function
+  onClick: (e: React.MouseEvent) => void
 }
 
 export default function OverlayLayer({

diff --git a/components/PillTagTrend.tsx b/components/PillTagTrend.tsx
@@ -4,7 +4,6 @@ import {
   mdiChevronDown,
   mdiAlertCircleOutline,
   mdiInformationOutline,
-  mdiCheckAll,
   mdiCheckCircleOutline,
   mdiAlertOutline,
 } from '@mdi/js'

diff --git a/components/SectionFullScreen.tsx b/components/SectionFullScreen.tsx
@@ -8,7 +8,7 @@ type Props = {
   children: ReactNode
 }
 
-export default function SectionFullScreen({ bg, children }) {
+export default function SectionFullScreen({ bg, children }: Props) {
   const darkMode = useAppSelector((state) => state.style.darkMode)
 
   let componentClass = 'flex min-h-screen items-center justify-center '

diff --git a/components/UserAvatar.tsx b/components/UserAvatar.tsx
@@ -1,5 +1,5 @@
 /* eslint-disable @next/next/no-img-element */
-// Why disabled: 
+// Why disabled:
 // avatars.dicebear.com provides svg avatars
 // next/image needs dangerouslyAllowSVG option for that