Add basic unittests for bulk group registration

Author: yhabteab

test/CMakeLists.txt

@@ -230,6 +230,7 @@ add_boost_test(base
     icinga_checkresult/service_flapping_notification
     icinga_checkresult/suppressed_notification
     icinga_dependencies/multi_parent
+    icinga_dependencies/push_dependency_groups_to_registry
     icinga_dependencies/default_redundancy_group_registration_unregistration
     icinga_dependencies/simple_redundancy_group_registration_unregistration
     icinga_dependencies/mixed_redundancy_group_registration_unregsitration

test/icinga-dependencies.cpp

@@ -27,8 +27,9 @@ static Dependency::Ptr CreateDependency(Checkable::Ptr parent, Checkable::Ptr ch
 
 static void RegisterDependency(Dependency::Ptr dep, const String& redundancyGroup)
 {
+	std::vector<DependencyGroup::Ptr> changedGroups;
 	dep->SetRedundancyGroup(redundancyGroup);
-	dep->GetChild()->AddDependency(dep, true);
+	dep->GetChild()->AddDependency(dep, &changedGroups);
 	dep->GetParent()->AddReverseDependency(dep);
 }
 
@@ -145,6 +146,53 @@ BOOST_AUTO_TEST_CASE(multi_parent)
 	BOOST_CHECK(childHost->IsReachable() == false);
 }
 
+BOOST_AUTO_TEST_CASE(push_dependency_groups_to_registry)
+{
+	Checkable::Ptr childHostC(CreateHost("C"));
+	Checkable::Ptr childHostD(CreateHost("D"));
+	std::set<Dependency::Ptr> dependencies; // Keep track of all dependencies to avoid unexpected deletions.
+	for (auto& parent : {String("A"), String("B"), String("E")}) {
+		Dependency::Ptr depC(CreateDependency(CreateHost(parent), childHostC, "depC" + parent));
+		Dependency::Ptr depD(CreateDependency(depC->GetParent(), childHostD, "depD" + parent));
+		if (parent == "A") {
+			Dependency::Ptr depCA2(CreateDependency(depC->GetParent(), childHostC, "depCA2"));
+			childHostC->AddDependency(depCA2, nullptr);
+			dependencies.emplace(depCA2);
+		} else {
+			depC->SetRedundancyGroup("redundant", true);
+			depD->SetRedundancyGroup("redundant", true);
+
+			if (parent == "B") { // Create an exact duplicate of depC, but with a different name.
+				Dependency::Ptr depCB2(CreateDependency(depC->GetParent(), childHostC, "depCB2"));
+				depCB2->SetRedundancyGroup("redundant", true);
+				childHostC->AddDependency(depCB2, nullptr);
+				dependencies.emplace(depCB2);
+			}
+		}
+		childHostC->AddDependency(depC, nullptr);
+		childHostD->AddDependency(depD, nullptr);
+		dependencies.insert({depC, depD});
+	}
+
+	childHostC->PushDependencyGroupsToRegistry();
+	childHostD->PushDependencyGroupsToRegistry();
+
+	BOOST_TEST(childHostC->GetDependencyGroups() == childHostD->GetDependencyGroups(), boost::test_tools::per_element());
+	BOOST_CHECK_EQUAL(2, DependencyGroup::GetRegistrySize());
+	for (auto& checkable : {childHostC, childHostD}) {
+		BOOST_CHECK_EQUAL(2, checkable->GetDependencyGroups().size());
+		for (auto& dependencyGroup : checkable->GetDependencyGroups()) {
+			if (dependencyGroup->IsRedundancyGroup()) {
+				BOOST_CHECK_EQUAL(5, dependencyGroup->GetMemberCount());
+				BOOST_CHECK_EQUAL(checkable == childHostC ? 5 : 3, checkable->GetDependencies().size());
+			} else {
+				BOOST_CHECK_EQUAL(3, dependencyGroup->GetMemberCount());
+				BOOST_CHECK_EQUAL(checkable == childHostC ? 5 : 3, checkable->GetDependencies().size());
+			}
+		}
+	}
+}
+
 BOOST_AUTO_TEST_CASE(default_redundancy_group_registration_unregistration)
 {
 	Checkable::Ptr childHostC(CreateHost("C"));