EntryForm: Validate entry duration against its frequency

Entry duration should be shorter than their frequency for recurrent entries.

Author: raviks789

application/forms/EntryForm.php

@@ -180,6 +180,20 @@ protected function assemble()
                             );
 
                             return false;
+                        } elseif ($this->getValue('frequency') !== self::NO_REPEAT) {
+                            /** @var Frequency $frequency */
+                            $frequency = $this->getValue();
+                            $next = $frequency->getNextDue($value);
+
+                            if ($endTime > $next) {
+                                $validator->addMessage(
+                                    $this->translate(
+                                        'The entry should end before the next occurrence.'
+                                    )
+                                );
+
+                                return false;
+                            }
                         }
 
                         return true;