From 17cd2ffda5cbfaef5310d0f0ec60b51142c80588 Mon Sep 17 00:00:00 2001 From: Will Beasley Date: Tue, 13 Apr 2021 23:48:00 -0500 Subject: [PATCH 1/2] decrease version; remove line about LazyData ``` * checking LazyData ... NOTE 'LazyData' is specified without a 'data' directory ``` https://www.mail-archive.com/r-package-devel@r-project.org/msg06703.html --- DESCRIPTION | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 867dc78..7824899 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,5 +1,5 @@ Package: dataverse -Version: 0.4.0 +Version: 0.3.8 Title: Client for Dataverse 4+ Repositories Authors@R: c(person(given = "Will", @@ -54,7 +54,6 @@ Description: Provides access to Dataverse APIs (version enabling data search, retrieval, and deposit. For Dataverse versions <= 3.0, use the archived 'dvn' package . License: GPL-2 -LazyData: true URL: https://iqss.github.io/dataverse-client-r/, https://dataverse.org/, https://github.com/iqss/dataverse-client-r BugReports: https://github.com/iqss/dataverse-client-r/issues VignetteBuilder: knitr From 8b237c5adf96c47327c8ddf38794aa309467895b Mon Sep 17 00:00:00 2001 From: Will Beasley Date: Wed, 14 Apr 2021 00:17:12 -0500 Subject: [PATCH 2/2] update cran comments --- cran-comments.md | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 0071084..f6183dd 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,26 +1,40 @@ Description ----------------------------------------------- -In response to a January notification from Brian Ripley, the tests are now skipped if the server cannot be contacted. Unfortunately I couldn't attend to this package quickly enough, and understandably it was archived a few days ago. +After Brian Ripley's latest instructions, we have decided we shouldn't rely +on nightly CRAN builds for testing the package's interactions with servers. +Even if the servers are reachable. All those tests are now skipped on CRAN +(with `testthat::skip_on_cran()`) and instead will run on nightly +GitHub Actions builds. -All checks and tests are passing on win-builder, Travis, R-hub, and my two local machines. +In this specific case, the server software (that our package calls) had +accidentally released a backwards-incompatible change that our tests caught +on the dev server, fortunately before it was released to production servers. +We are grateful that CRAN helped alert everyone to the problem, but we do not +wish to further burden Brian and the rest of the CRAN team as you +graciously donate to the community. -We just made another modification (related to the previous rejections this week) to account for different sorting orders that I assume are related to different platforms. They hadn't appeared in any of our tests. We also changed a `donttest{}` to a `dontrun{}` example and updated an old url in a vignette that were missed in all these test environments. - -I'm sorry these resubmissions have taken more of your time. Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley +Thank you for taking the time to review the submission, and please tell me if +there's something else I should do for CRAN. -Will Beasley Test environments ----------------------------------------------- 1. Local Ubuntu, R 4.0.4 -1. Local Win10, R 4.0.4 Patched -1. [win-builder](https://win-builder.r-project.org/E5QE5o3DKIJF/), development version. -1. [Travis CI](https://travis-ci.org/github/IQSS/dataverse-client-r), Ubuntu 18.04 LTS -1. [R-hub](https://builder.r-hub.io/status/dataverse_0.3.7.tar.gz-76e7f9d49abc47f598fe0d8ddedcc450). +2. Local Win10, R 4.0.4 Patched +3. [win-builder](), development version. +4. [R-hub](https://builder.r-hub.io/status/dataverse_0.3.8.tar.gz-cdb69dcae8044c28a925dae7004f2e66). +5. [GitHub Actions](https://github.com/IQSS/dataverse-client-r/actions) + * os: macOS-latest , r: 'release' + * os: windows-latest , r: 'devel' + * os: windows-latest , r: 'release' + * os: ubuntu-latest , r: 'devel' + * os: ubuntu-latest , r: 'release' R CMD check results ----------------------------------------------- -* No ERRORs or WARNINGs on any builds. -* There are two NOTEs. One about the package being archived, and another about possibly misspelled words "APIs" and "Dataverse"; both spellings are intentional. +* No ERRORs, WARNINGs, or NOTEs on any builds. + +* In the past, there has been a note about possibly misspelled words "APIs" and "Dataverse". If they appear on your machines, both spellings are intentional.