IONOS(ci): replace Docker build-push with Kaniko in workflow - #273
Closed
bromiesTM wants to merge 1 commit into
Closed
IONOS(ci): replace Docker build-push with Kaniko in workflow#273bromiesTM wants to merge 1 commit into
bromiesTM wants to merge 1 commit into
Conversation
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
There was a problem hiding this comment.
Pull request overview
Updates the HiDrive “artifact → ghcr.io” GitHub Actions job to build/push the container image using Kaniko (run via docker run) instead of docker/build-push-action, aligning the workflow with a Kaniko-based build/push approach.
Changes:
- Removed
docker/login-action+docker/build-push-actionusage for the ghcr.io push job. - Added a step that writes a Docker
config.jsonfor Kaniko registry auth and runs the Kaniko executor to build/push to the tags produced bydocker/metadata-action. - Added cleanup of the temporary Kaniko Docker config directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+516
to
+520
| docker run --rm \ | ||
| -v "${{ github.workspace }}:/workspace" \ | ||
| -v "/tmp/kaniko-config:/kaniko/.docker" \ | ||
| gcr.io/kaniko-project/executor:latest \ | ||
| --context=/workspace \ |
Comment on lines
+513
to
+525
| # Convert newline-separated tags to --destination flags | ||
| DESTINATIONS=$(echo "${{ steps.meta.outputs.tags }}" | sed 's/^/--destination=/' | tr '\n' ' ') | ||
|
|
||
| docker run --rm \ | ||
| -v "${{ github.workspace }}:/workspace" \ | ||
| -v "/tmp/kaniko-config:/kaniko/.docker" \ | ||
| gcr.io/kaniko-project/executor:latest \ | ||
| --context=/workspace \ | ||
| --dockerfile=/workspace/Dockerfile \ | ||
| ${DESTINATIONS} \ | ||
| --cache=true \ | ||
| --cache-repo=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}/cache \ | ||
| --cache-ttl=24h |
bromiesTM
marked this pull request as draft
July 8, 2026 07:58
Author
|
Kaniko is no longer maintained, so we will keep using docker push action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.