workbench re-audit: the logical zoom is still the strip, fit hides the first column, and five smaller things (#393)

[lex00]

The second pass of #393's audit, on feat/audit-393 at f68b891 (PR #395, stacked on #392), the same five estates at every zoom, driven the same way: headless Chrome over the real SPA, the ⌘K palette picking each zoom, plus this time the address search, the collapse toggle, the inspect pane on a bound and an unowned card, and all four panel tabs. terralith-4 (301, all bound), terralith-4-adopt (84 bound · 85 unowned · 132 not observed), choudoufu-workbench (4 members, 42), waterpark (Terraform, 5 roots, 58 / 219 at attributes), choudoufu-cohort-iam-ecr (6).

What #393 asked for, and holds

• terralith-4 boots on resources at 1.58:1, 301 legible cards, two module sub-boxes, badge 301 resources · all bound; the adopt estate at 1.5:1 with 301 resources · 84 bound · 85 unowned · 132 neutral; waterpark at 1.05:1 with a badge per root; the workbench at 0.93:1.
• 266 edges on the terralith at detail 2; the attachments sit beside their roles.
• ⌘K team_0007_role → one row, Enter selects the card, the viewBox moves from 0 0 8099 5138 to -505 862 2583 1638, the card is inside the viewport, the inspect pane shows it. Two members declaring one address give two rows with the member on the second line.
• Legend, statusbar, Model tab and NEEDS ATTENTION all say bound / unowned / pending / not observed on a choudoufu estate; the UNOWNED inspect leads with tofu-estate=… tofu-address=… and a copy button.
• runtime and ops are not offered on any of the five; "estate of 1 project"; the roots note is short in the strip, whole in the Model tab and on the tooltip, and survives the logical zoom.
• Zero console errors and zero non-2xx requests on every estate at every zoom.

What this pass found

1. The logical zoom is still the strip, on every estate. terralith-4 165:1, terralith-4-adopt 166:1, waterpark 20:1, choudoufu-workbench 19:1, iam-ecr 5.6:1. The wrap and the component packing live in renderGraph; the logical branches render through renderArchitecture (src/server.ts four call sites), which got none of it. On a choudoufu estate the logical picture is also the same graph as resources with the boxes gone (boxes: 1), so the zoom currently subtracts information and adds width.

2. The floating panel hides the left edge of every fit. At boot the first column of cards sits under the View panel (x < 285px): on terralith-4 a whole column, on waterpark half the github box. "fit" fits the pane, not the pane minus the panel; the cards are reachable only by collapsing the panel or panning.

3. composites on a Terraform estate undoes the resources picture. waterpark at detail 1: the five root boxes collapse to one box named access (boxes: 1) and every card is titled with its full identity/module.course_author/aws_iam_… id again — the root boxes and the card faces apply at detail 2 and 3 only. On a choudoufu estate composites and attributes are byte-identical to resources; the zoom is a no-op and the strip says nothing about it.

4. The card-face collision rule defeats itself on a split estate. The workbench keeps every title as monolith/aws_cloudwatch_log_group.team_a_0, team-a/aws_cloudwatch_log_group.team_a_0, because "a label two cards would share is used for neither" is evaluated across the whole graph — and a split estate is exactly one address declared in several boxes. The box already disambiguates; the rule should be per box.

5. One word of chant's vocabulary leaks into the inspect pane. LIVE → ownership: foreign on an unowned card whose status row says unowned (src/choudoufu-live.ts sets ownership: "foreign"; the pane prints it raw).

6. The collapse toggle re-runs the live read. "Collapse large boxes" and "Expand all" each re-fetch /api/overlay?…&collapse=1, which re-runs live-ls and live-plan: 4 s on the terralith, with the graph frozen behind "loading resources · live…" meanwhile. The collapse is a render decision over a document behold already holds. Also: the collapsed view's statusbar comes back with the old "no edges at this detail — sourceRef/dependsOn …" note, which #393 retired.

7. Small. The components note on a lone estate says "a composed estate"; the badge and box title on terralith-4 render at ~7px at fit (the box is 8000 units wide); the adopt copy line wraps onto three lines in the pane.

Definition of done

• Logical zoom under 4:1 on all five, through the same passes the entity graph gets, and boxes kept on a choudoufu estate.
• Fit excludes the panel's footprint (or the panel yields), so the first column is on screen at boot.
• Composites on a Terraform estate keeps the root boxes and the card faces; a zoom that changes nothing on a member kind says so in the strip.
• Split-estate titles are the address alone; the collision rule is per box.
• No foreign anywhere on a choudoufu card.
• Collapse and expand are served from the cached overlay document — no choudoufu spawn — and carry the current note.
• The re-audit driver (this pass's script) runs as part of e2e/workbench-e2e.sh for the aspect ratio of every zoom, not only resources.

[lex00]

The re-audit's findings are still open; everything #393 fixed is in 0.18.0.