Keep coherence between illustrations of GridSearchCV #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Dec 1, 2023
| # can be shown schematically as follows | ||
| # | ||
| #  |
Collaborator
There was a problem hiding this comment.
I would keep the figure in this notebook too, this helps having both figures (train-test split + GridSearchCV and nested cross validation) in the same notebook to be able to see how to go from one to the other without having to find where in a previous notebook the other diagram was shown.
Collaborator
There was a problem hiding this comment.
I agree, it's fine to repeat this diagram here because it matches the context and the title of the section.
ArturoAmorQ
commented
Jan 19, 2024
ArturoAmorQ
pushed a commit
to student-ChestaVashishtha/scikit-learn-mooc
that referenced
this pull request
Jul 29, 2025
added 3 commits
July 30, 2025 10:44
ArturoAmorQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
moves the illustration of GridSearchCV to the first GridSearchCV notebook;re-works the progression of the concepts to have a more linear narrative;Discussing with @ogrisel we thought that this one can be updated in FUN even if new users start having a slightly different version, but I would rather have the @glemaitre and @lesteve opinions.
Edit: #752 was fixed by #847, as it was merged before the current PR. It's scope then changed to improve the wording for better coherence between the Hyperparameter tuning by grid-search and the Evaluation and hyperparameter tuning notebooks.