Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid p-values to be zero #251

Closed
jaime-cespedes-sisniega opened this issue Jul 23, 2023 · 0 comments · Fixed by #275
Closed

Avoid p-values to be zero #251

jaime-cespedes-sisniega opened this issue Jul 23, 2023 · 0 comments · Fixed by #275
Labels
enhancement New feature or request needs triage Issue requires triage

Comments

@jaime-cespedes-sisniega
Copy link
Contributor

Describe the workflow you want to enable

Avoid p-values to be zero be adding an additional argument to PermutationTestDistanceBased callback.

Describe your proposed solution

Add a boolean argument named conservative to PermutationTestDistanceBased callback. If true, p-values are computed using (b+1)/(m+1) formula which avoids zero value , otherwise p-values are computed using current formula b/m that can produce zero values.

Describe alternatives you've considered, if relevant

Another more advanced option would be to use equation (2) from Permutation P-values Should Never Be Zero:
Calculating Exact P-values When Permutations Are Randomly Drawn
.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue requires triage
Projects
None yet
1 participant