Skip to content

Commit f4ac0d1

Browse files
authored
fix: specify the maximum version of requests to avoid regression (#194)
Version `2.23.3` of the `requests` package broke our custom `SSLHTTPAdapter`. This commit defines the maximum version of that package, to make sure it will continue working without an issue. Note that, this is a short term solution only. For more details see this issue: psf/requests#6730 Signed-off-by: Norbert Biczo <[email protected]>
1 parent 1c20738 commit f4ac0d1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

ibm_cloud_sdk_core/utils.py

+2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import dateutil.parser as date_parser
3232

3333

34+
# pylint: disable=fixme
35+
# TODO: revert the change in the `requirement.txt` once this class become deprecated!
3436
class SSLHTTPAdapter(HTTPAdapter):
3537
"""Wraps the original HTTP adapter and adds additional SSL context."""
3638

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
requests>=2.31.0,<3.0.0
1+
requests>=2.31.0,<2.32.3
22
urllib3>=2.1.0,<3.0.0
33
python_dateutil>=2.8.2,<3.0.0
44
PyJWT>=2.8.0,<3.0.0

0 commit comments

Comments
 (0)