Skip to content

Commit b620c9f

Browse files
committed
fix: jupyterlab 3 support and other misc changes
1 parent a78edfc commit b620c9f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+4578
-2621
lines changed

.dockerignore

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,9 @@
11
Dockerfile
2+
LICENSE
3+
MANIFEST.in
4+
Makefile
5+
README.md
6+
docker-compose.yaml
7+
docs/
8+
minio-data/
9+
*.ipynb

.eslintignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
node_modules
2+
dist
3+
coverage
4+
**/*.d.ts
5+
tests

.eslintrc.js

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
module.exports = {
2+
extends: [
3+
'eslint:recommended',
4+
'plugin:@typescript-eslint/eslint-recommended',
5+
'plugin:@typescript-eslint/recommended',
6+
'plugin:prettier/recommended'
7+
],
8+
parser: '@typescript-eslint/parser',
9+
parserOptions: {
10+
project: 'tsconfig.json',
11+
sourceType: 'module'
12+
},
13+
plugins: ['@typescript-eslint'],
14+
rules: {
15+
'@typescript-eslint/naming-convention': [
16+
'error',
17+
{
18+
selector: 'interface',
19+
format: ['PascalCase'],
20+
custom: {
21+
regex: '^I[A-Z]',
22+
match: true
23+
}
24+
}
25+
],
26+
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
27+
'@typescript-eslint/no-explicit-any': 'off',
28+
'@typescript-eslint/no-namespace': 'off',
29+
'@typescript-eslint/no-use-before-define': 'off',
30+
'@typescript-eslint/quotes': [
31+
'error',
32+
'single',
33+
{ avoidEscape: true, allowTemplateLiterals: false }
34+
],
35+
curly: ['error', 'all'],
36+
eqeqeq: 'error',
37+
'prefer-arrow-callback': 'error'
38+
}
39+
};

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ about: Create a report to help us improve
44
title: ''
55
labels: bug
66
assignees: reevejd
7-
87
---
98

109
**Describe the bug**
1110
A clear and concise description of what the bug is.
1211

1312
**To Reproduce**
1413
Steps to reproduce the behavior:
14+
1515
1. Go to '...'
1616
2. Click on '....'
1717
3. Scroll down to '....'
@@ -24,9 +24,10 @@ A clear and concise description of what you expected to happen.
2424
If applicable, add screenshots to help explain your problem.
2525

2626
**Desktop (please complete the following information):**
27-
- OS: [e.g. Windows 10]
28-
- Browser [e.g. chrome]
29-
- Version of `jupyterlab-s3-browser` extension [e.g. 0.6.0]
27+
28+
- OS: [e.g. Windows 10]
29+
- Browser [e.g. chrome]
30+
- Version of `jupyterlab-s3-browser` extension [e.g. 0.6.0]
3031

3132
**Additional context**
3233
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: Suggest an idea for this project
44
title: ''
55
labels: enhancement
66
assignees: ''
7-
87
---
98

109
**Is your feature request related to a problem? Please describe.**

.github/workflows/main.yml

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
name: CI
2+
3+
on: push
4+
# on:
5+
# push:
6+
# branches: 'master'
7+
# schedule:
8+
# - cron: '0 0 * * *'
9+
10+
jobs:
11+
build:
12+
13+
runs-on: ubuntu-20.04
14+
15+
steps:
16+
- name: Checkout
17+
uses: actions/checkout@v2
18+
- name: Install node
19+
uses: actions/setup-node@v1
20+
with:
21+
node-version: '14.x'
22+
- name: Install Python
23+
uses: actions/setup-python@v2
24+
with:
25+
python-version: '3.7'
26+
architecture: 'x64'
27+
28+
- name: Setup pip cache
29+
uses: actions/cache@v2
30+
with:
31+
path: ~/.cache/pip
32+
key: pip-3.7-${{ hashFiles('package.json') }}
33+
restore-keys: |
34+
pip-3.7-
35+
pip-
36+
- name: Get yarn cache directory path
37+
id: yarn-cache-dir-path
38+
run: echo "::set-output name=dir::$(yarn cache dir)"
39+
- name: Setup yarn cache
40+
uses: actions/cache@v2
41+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
42+
with:
43+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
44+
key: yarn-${{ hashFiles('**/yarn.lock') }}
45+
restore-keys: |
46+
yarn-
47+
48+
- name: Install dependencies
49+
run: |
50+
python -m pip install --upgrade pip
51+
pip install wheel twine setuptools packaging jupyterlab~=3.0 jupyter_packaging~=0.7.9
52+
jlpm
53+
# python -m pip install -e .[dev]
54+
55+
- name: Create server extension # and pip install
56+
run: |
57+
jlpm run build:prod
58+
# jupyter labextension develop . --overwrite
59+
# pip install .[dev] && jupyter serverextension enable --py jupyterlab_s3_browser
60+
61+
- name: Package extension
62+
run: |
63+
python setup.py sdist bdist_wheel
64+
65+
- name: Publish a Python distribution to PyPI
66+
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
67+
uses: pypa/gh-action-pypi-publish@master
68+
with:
69+
user: __token__
70+
password: ${{ secrets.PYPI_API_TOKEN }}
71+
72+
- name: Publish labextension NPM
73+
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
74+
uses: JS-DevTools/npm-publish@v1
75+
with:
76+
token: ${{ secrets.NPM_TOKEN }}

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
.env
2+
**/.minio.sys/*
23
lib/
34
dist/
45
__pycache__/
@@ -12,5 +13,8 @@ jupyterlab_s3_browser.egg-info/
1213
.ipynb_checkpoints/
1314
.jupyterlab/
1415
*.ipynb
16+
*.pipeline
1517
.coverage
1618
htmlcov/
19+
jupyterlab_s3_browser/labextension
20+
*.tsbuildinfo

.prettierignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
node_modules
2+
**/node_modules
3+
**/lib
4+
**/package.json
5+
jupyterlab_s3_browser
6+
minio-data

.prettierrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"singleQuote": true,
3+
"trailingComma": "none",
4+
"arrowParens": "avoid"
5+
}

.travis.yml

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)