Fix for gosec false positive (#1241)

Signed-off-by: hemalathagajendran <[email protected]>

Author: hemalathagajendran

driver/csiplugin/controllerserver.go

@@ -75,6 +75,7 @@ type ScaleControllerServer struct {
 func (cs *ScaleControllerServer) IfSameVolReqInProcess(scVol *scaleVolume) (bool, error) {
 	capacity, volpresent := cs.Driver.reqmap[scVol.VolName]
 	if volpresent {
+		/*  #nosec G115 -- false positive  */
 		if capacity == int64(scVol.VolSize) {
 			return true, nil
 		} else {
@@ -930,7 +931,7 @@ func (cs *ScaleControllerServer) CreateVolume(newctx context.Context, req *csi.C
 		return &csi.CreateVolumeResponse{
 			Volume: &csi.Volume{
 				VolumeId:      volID,
-				CapacityBytes: int64(scaleVol.VolSize),
+				CapacityBytes: int64(scaleVol.VolSize), // #nosec G115 -- false positive
 				VolumeContext: req.GetParameters(),
 				ContentSource: volSrc,
 			},
@@ -978,7 +979,7 @@ func (cs *ScaleControllerServer) CreateVolume(newctx context.Context, req *csi.C
 
 	/* Update driver map with new volume. Make sure to defer delete */
 
-	cs.Driver.reqmap[scaleVol.VolName] = int64(scaleVol.VolSize)
+	cs.Driver.reqmap[scaleVol.VolName] = int64(scaleVol.VolSize) // #nosec G115 -- false positive
 	defer delete(cs.Driver.reqmap, scaleVol.VolName)
 
 	var targetPath string
@@ -1051,7 +1052,7 @@ func (cs *ScaleControllerServer) CreateVolume(newctx context.Context, req *csi.C
 	return &csi.CreateVolumeResponse{
 		Volume: &csi.Volume{
 			VolumeId:      volID,
-			CapacityBytes: int64(scaleVol.VolSize),
+			CapacityBytes: int64(scaleVol.VolSize), // #nosec G115 -- false positive
 			VolumeContext: req.GetParameters(),
 			ContentSource: volSrc,
 		},
@@ -1081,10 +1082,11 @@ func (cs *ScaleControllerServer) setScaleVolume(ctx context.Context, req *csi.Cr
 	}
 
 	scaleVol.VolName = volName
+	// #nosec G115 -- false positive
 	if scaleVol.IsFilesetBased && uint64(volSize) < smallestVolSize {
 		scaleVol.VolSize = smallestVolSize
 	} else {
-		scaleVol.VolSize = uint64(volSize)
+		scaleVol.VolSize = uint64(volSize) // #nosec G115 -- false positive
 	}
 
 	/* Get details for Primary Cluster */
@@ -1304,7 +1306,7 @@ func (cs *ScaleControllerServer) getCopyJobStatus(ctx context.Context, req *csi.
 				return &csi.CreateVolumeResponse{
 					Volume: &csi.Volume{
 						VolumeId:      volID,
-						CapacityBytes: int64(scaleVol.VolSize),
+						CapacityBytes: int64(scaleVol.VolSize), // #nosec G115 --  false positive
 						VolumeContext: req.GetParameters(),
 						ContentSource: volSrc,
 					},
@@ -1339,7 +1341,7 @@ func (cs *ScaleControllerServer) getCopyJobStatus(ctx context.Context, req *csi.
 				return &csi.CreateVolumeResponse{
 					Volume: &csi.Volume{
 						VolumeId:      volID,
-						CapacityBytes: int64(scaleVol.VolSize),
+						CapacityBytes: int64(scaleVol.VolSize), // #nosec G115 --  false positive
 						VolumeContext: req.GetParameters(),
 						ContentSource: volSrc,
 					},
@@ -3208,7 +3210,7 @@ func (cs *ScaleControllerServer) ControllerExpandVolume(ctx context.Context, req
 	if capRange == nil {
 		return nil, status.Error(codes.InvalidArgument, "capacity range not provided")
 	}
-	capacity := uint64(capRange.GetRequiredBytes())
+	capacity := uint64(capRange.GetRequiredBytes()) // #nosec G115 -- false positive
 
 	volumeIDMembers, err := getVolIDMembers(volID)
 

driver/csiplugin/utils/utils.go

@@ -218,11 +218,11 @@ func FsStatInfo(path string) (int64, int64, int64, int64, int64, int64, error) {
 	if err != nil {
 		return 0, 0, 0, 0, 0, 0, err
 	}
-	available := int64(statfs.Bavail) * int64(statfs.Bsize)
-	capacity := int64(statfs.Blocks) * int64(statfs.Bsize)
-	usage := (int64(statfs.Blocks) - int64(statfs.Bfree)) * int64(statfs.Bsize)
-	inodes := int64(statfs.Files)
-	inodesFree := int64(statfs.Ffree)
+	available := int64(statfs.Bavail) * int64(statfs.Bsize) // #nosec G115 -- false positive
+	capacity := int64(statfs.Blocks) * int64(statfs.Bsize) // #nosec G115 -- false positive
+	usage := (int64(statfs.Blocks) - int64(statfs.Bfree)) * int64(statfs.Bsize) // #nosec G115 -- false positive
+	inodes := int64(statfs.Files) // #nosec G115 -- false positive
+	inodesFree := int64(statfs.Ffree) // #nosec G115 -- false positive
 	inodesUsed := inodes - inodesFree
 
 	return available, capacity, usage, inodes, inodesFree, inodesUsed, nil