Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to make overlay usable as a modal dialog #5

Open
mehaase opened this issue Mar 18, 2020 · 1 comment
Open

Add features to make overlay usable as a modal dialog #5

mehaase opened this issue Mar 18, 2020 · 1 comment

Comments

@mehaase
Copy link
Contributor

mehaase commented Mar 18, 2020

The overlay already looks a bit like a modal dialog, but it lacks a built-in close widget. Ideally it would:

  • Have an option to display a close widget.
  • Have an option to close when the user presses the escape key.
  • Have a way to wire a button inside the dialog to close the widget. For example, the caller may want to put a cancel button inside the dialog.

The first two could be the same option, i.e. [closable]='true'. The third item needs to be separate.

@mehaase
Copy link
Contributor Author

mehaase commented Mar 18, 2020

Note to self: I have code to do the first two in a private project. The third item will require some Angular black magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant