Dataset ID in Changes graph tooltip is .../0, but one in the list below graph is .../1

[jhutar]

Describe the bug

Dataset ID in Changes graph tooltip says Change in run .../0, but one in the list below graph says .../1

To Reproduce

https://horreum.corp.redhat.com/test/306?fingerprint=%7B%22.metadata.scenario.name%22%3A%22mvp%22%7D&end=1729116000000

Version

Current in Prod

Browser

firefox-130.0.1-1.fc40.x86_64

[lampajr]

Hi @jhutar,

This is kind of intended (at least done on purpose) as you can see

Horreum/horreum-web/src/domain/alerting/ChangeTable.tsx

Lines 196 to 198 in 96d0c44

	<NavLink to={`/run/${dataset.runId}#dataset${dataset.ordinal}`}>
	{dataset.runId}/{dataset.ordinal + 1}
	</NavLink>

but I agree that this could be misleading.

My guess is that, initially, the idea was to keep Dataset ordering starting from 1 in the UI (whereas the internal ordering, in the backend, starts from 0).

@johnaohara I think we can simply remove that ordinal + 1 and show in the UI <dataset>/0 to avoid any confusion, anything against this?

If we proceed with this change, I think we should also apply the same in the datasets tab

[edit] Created a proposal here #2106