Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1621: Remove Stale Feature Flag - fflag_perf_back_lsdv_4695_update_prediction_query_to_use_direct_project_relation #7002

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jan 30, 2025

Removing stale feature flag

fflag_perf_back_lsdv_4695_update_prediction_query_to_use_direct_project_relation -> True

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 347194f
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/679c0a60b84b7f00081aa351

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 347194f
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/679c0a60bb680400089d8137

…v_4695_update_prediction_query_to_use_direct_project_relation
@luarmr luarmr force-pushed the fb-optic-1621/remove-stale-feature-flag---fflagperfbacklsdv4695updatepredictionquerytousedirectprojectrelation branch from 2dc4e51 to 347194f Compare January 30, 2025 23:25
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (6ecd15e) to head (347194f).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/projects/models.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7002      +/-   ##
===========================================
+ Coverage    76.90%   76.93%   +0.03%     
===========================================
  Files          175      175              
  Lines        14166    14154      -12     
===========================================
- Hits         10894    10890       -4     
+ Misses        3272     3264       -8     
Flag Coverage Δ
pytests 76.93% <83.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr merged commit 687780f into develop Feb 3, 2025
43 checks passed
luarmr added a commit that referenced this pull request Feb 3, 2025
…v_4695_update_prediction_query_to_use_direct_project_relation (#7002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants