This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: OPTIC-124: Save and update have success/fail toast messages #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis1282
changed the title
bmartel
reviewed
Oct 17, 2023
bmartel
suggested changes
Oct 17, 2023
hlomzik
suggested changes
Oct 17, 2023
src/sdk/lsf-sdk.js
Outdated
| @@ -563,7 +563,12 @@ export class LSFWrapper { | |||
| { body }, | |||
| // don't react on duplicated annotations error | |||
| { errorHandler: result => result.status === 409 }, | |||
| ); | |||
| ).then(result => { | |||
There was a problem hiding this comment.
promise chain is broken here because it doesn't pass result through. I'd remove current returns and added final return result the same way as in "update" version.
There was a problem hiding this comment.
good catch, thanks!
Travis1282
force-pushed
the
fb-optic-124/save-and-update-toast
branch
from
417683d to
a73b540
Compare
bmartel
reviewed
Oct 19, 2023
bmartel
approved these changes
Oct 19, 2023
hlomzik
approved these changes
Oct 19, 2023
|
/git merge master
|
|
/git merge master
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
Toast messages should be displayed on save, update actions as well as draft save on leave
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)