Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: various cleanups #180

Merged
merged 1 commit into from
Oct 26, 2023
Merged

workflows: various cleanups #180

merged 1 commit into from
Oct 26, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 26, 2023

  • Remove CI on master push. This is a low volume repository so spending an extra 20-25 minutes is a waste of self-hosted resources when we don't allow direct pushes without a pull request. If there's a concern of two simultaneous PRs causing problems only when merged together, we can enable "Require branches to be up to date before merging", which will solve those concerns with minimal annoyance given the PR volume.
  • Remove run attempt from ephemeral names as we don't need that anymore.
  • Scope permissions slightly more tightly
  • Minor cleanup of unused stuff

@Bo98 Bo98 merged commit 33568fd into Homebrew:master Oct 26, 2023
4 checks passed
@Bo98 Bo98 deleted the workflow-tweaks branch October 26, 2023 20:30
@MikeMcQuaid
Copy link
Member

  • Remove CI on master push. This is a low volume repository so spending an extra 20-25 minutes is a waste of self-hosted resources when we don't allow direct pushes without a pull request. If there's a concern of two simultaneous PRs causing problems only when merged together, we can enable "Require branches to be up to date before merging", which will solve those concerns with minimal annoyance given the PR volume.

Could we keep brew test-bot --only-tap-syntax running on a Linux runner for the master branch, please?

@MikeMcQuaid
Copy link
Member

Otherwise: all agreed, nice work 👍🏻

@Bo98
Copy link
Member Author

Bo98 commented Nov 24, 2023

Done in 0f7b1d1

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants