Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Oct 21, 2025

These will be used for code review.

Copilot AI review requested due to automatic review settings October 21, 2025 15:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2025
@MikeMcQuaid MikeMcQuaid enabled auto-merge October 21, 2025 15:23
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense! 💯

@SMillerDev
Copy link
Member

Is it a problem copilot can't review this?

@MikeMcQuaid
Copy link
Member Author

@SMillerDev don't think so no

@botantony botantony removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 24, 2025
@botantony botantony force-pushed the copilot-instructions branch from 94e1de1 to 8453812 Compare October 24, 2025 17:00
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 24, 2025
@botantony botantony removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 24, 2025
@MikeMcQuaid
Copy link
Member Author

@botantony thanks for the attempt but think this is worth waiting until next stable tag.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 27, 2025
@MikeMcQuaid MikeMcQuaid requested a review from a team as a code owner October 28, 2025 08:33
@github-actions github-actions bot added the workflows PR modifies GitHub Actions workflow files label Oct 28, 2025
These will be used for code review.
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit edfee4d Oct 28, 2025
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the copilot-instructions branch October 28, 2025 14:24
@botantony botantony mentioned this pull request Oct 28, 2025
Comment on lines -58 to -64
- name: Cache style cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: /home/linuxbrew/.cache/Homebrew/style
key: style-cache-${{ matrix.stable && 'stable-' || 'main-' }}${{ github.sha }}
restore-keys: style-cache-${{ matrix.stable && 'stable-' || 'main-' }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question: could this step affect the time it takes to complete tap_syntax job? Now it takes ~11 minutes instead of the usual ~4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yes, this was removed for debugging only. Will add it back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants