Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstall :delete_by_bundle_id #8211

Closed
vitorgalvao opened this issue Dec 18, 2014 · 6 comments
Closed

Add uninstall :delete_by_bundle_id #8211

vitorgalvao opened this issue Dec 18, 2014 · 6 comments
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated

Comments

@vitorgalvao
Copy link
Member

Refs #8210.

In a way, a better solution would be to automatically detect where an application is by their application bundle, but that would not work in cases like blast2go.rb since it would still leave its directory (and possibly sibling files) intact. It would still be nice to be able to do this on the casks that need nothing more, but that is for another issue.

We can detect the location on an app bundle by its bundle ID by leveraging spotlight, with mdfind kMDItemCFBundleIdentifier = <app_bundle_id>

In casks like battle-net.rb and vuze.rb, an uninstall :delete_by_bundle_id would be way more useful since it’d always work, and they would not need a caveat.

@rolandwalker
Copy link
Contributor

+1, with some safety features to avoid deleting something we didn't install.

We could also quasi-beta the safety features by using it first in zap stanzas.

@vitorgalvao vitorgalvao added the core Issue with Homebrew itself rather than with a specific cask. label Mar 15, 2015
@adidalal
Copy link
Contributor

adidalal commented Jan 5, 2016

Closing in favor of #16339.

@adidalal adidalal closed this as completed Jan 5, 2016
@vitorgalvao
Copy link
Member Author

@adityadalal924 Different issues. I did come across (and even considered closing) this one when drafting #16339, but they don’t depend on each other. Even if we never implement bundle_id, this could still come to fruition and be useful (and vice-versa).

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue which has not received any feedback for some time. label Feb 7, 2019
@vitorgalvao vitorgalvao removed the stale Issue which has not received any feedback for some time. label Feb 8, 2019
@reitermarkus
Copy link
Member

@vitorgalvao, is there any other cask other than battle-net that would benefit from this at this point?

@vitorgalvao
Copy link
Member Author

@reitermarkus Yes, let’s close it.

@lock lock bot added the outdated label Mar 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated
Projects
None yet
Development

No branches or pull requests

4 participants