Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mechvibes: update for hotfix #197910

Merged
merged 2 commits into from
Jan 11, 2025
Merged

mechvibes: update for hotfix #197910

merged 2 commits into from
Jan 11, 2025

Conversation

junian
Copy link
Contributor

@junian junian commented Jan 11, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@junian
Copy link
Contributor Author

junian commented Jan 11, 2025

The v2.6.3 binary no longer available to download. They replaced it with v2.6.3-hotfix.

@khipp
Copy link
Member

khipp commented Jan 11, 2025

Let's update the livecheck instead and add the -hotfix suffix to the version. This should ensure that the url won't break on the next release and potentially other hotfix releases after that.

  livecheck do
    url :url
    regex(/Mechvibes[._-]v?(\d+(?:\.\d+)+(?:-hotfix)?)\.dmg/i)
    strategy :github_latest do |json, regex|
      json["assets"]&.map do |asset|
        match = asset["name"]&.match(regex)
        next if match.blank?

        match[1]
      end
    end
  end

@daeho-ro daeho-ro changed the title Fix mechvibes.rb url to v2.6.3-hotfix mechvibes: update for hotfix Jan 11, 2025
@junian
Copy link
Contributor Author

junian commented Jan 11, 2025

@khipp sure, anything that works. Can you do it? I'm not familiar with live_check syntax.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 11, 2025
@p-linnane p-linnane merged commit 099e46d into Homebrew:master Jan 11, 2025
11 checks passed
@junian junian deleted the patch-1 branch January 12, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants