Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostty: remove terminfo #196646

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Dec 29, 2024

Ghostty always exports TERMINFO=/Applications/Ghostty.app/Contents/Resources/terminfo
This feature cannot be turned off in the Ghostty config.

Per macOS Sierra man terminfo:

If the environment variable TERMINFO is set, it is interpreted as the pathname of a
directory containing the compiled description you are working on. Only that directory
is searched.

IOW, linking from ~/.terminfo is redundant. These files can never be evaluated unless the user intentionally unsets $TERMINFO at runtime. Also, the iterm2 and kitty casks are doing fine without similar links.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

n/a

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Would like some maintainers who use Ghostty to weigh in before we merge.

cc: @bevanjkay @krehel

@krehel
Copy link
Member

krehel commented Dec 29, 2024

Fine for me. This follows kitty as mentioned with being embedded in the application path.

The same changes should be made to ghostty@tip

Ghostty always exports TERMINFO=/Applications/Ghostty.app/Contents/Resources/terminfo
Linking from ~/.terminfo is redundant
Ghostty always exports TERMINFO
Linking from ~/.terminfo is redundant
@rrotter
Copy link
Contributor Author

rrotter commented Dec 29, 2024

rebased, added same change to ghostty@tip

@bevanjkay bevanjkay merged commit 11d4708 into Homebrew:master Dec 29, 2024
13 checks passed
@bevanjkay
Copy link
Member

Thank you @rrotter

@rrotter rrotter deleted the ghostty-no-terminfo branch December 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants