Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixpin: update website and livecheck #196635

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

eleanordoesntcode
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


@eleanordoesntcode
Copy link
Contributor Author

hmm, weird, I got a download failure on one of the tests even though they download the same .dmg

Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

livecheck timed out when I tested this locally and then worked when I ran it again, so it may just be flaky.

Casks/p/pixpin.rb Outdated Show resolved Hide resolved
@samford samford added the livecheck Issues or PRs related to livecheck label Dec 29, 2024
@p-linnane
Copy link
Member

livecheck timed out when I tested this locally and then worked when I ran it again, so it may just be flaky.

Same. I tried manually pulling down the .dmg and couldn't get higher than 1.5 MB/s despite being on gigabit fiber. I feel like we see this from time to time with .cn domains.

@p-linnane p-linnane added the ready to merge PR can be merged once CI is green label Dec 29, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samford samford merged commit b97f50e into Homebrew:master Dec 29, 2024
11 checks passed
@samford samford removed the ready to merge PR can be merged once CI is green label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants