-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-integration: update livecheck (and update homepage) #196572
Conversation
We most likely need to disable this cask. As far as I can tell, Community Edition has been replaced by Developer Edition, but it requires registration: https://pentaho.com/pentaho-developer-edition/ |
I've filled out the form on the developer edition, and they're still redirecting to the download links we already have - I'll just switch the homepage to the new Developer Edition |
c4035cb
to
21c492c
Compare
I still think this should be disabled since it's not able to be downloaded without filling something out. If they're pushing a registration form is only a matter of time before they change the URLs. We've sene this plenty of times before. If other maintainers disagree, then I'm fine with moving forward with @khipp's suggestions. |
I've already seen quite a few apps on here behind a registration form that worked just fine, but I'm not very experienced here and not knowlegeable about all the policies, so I won't try to push (no pun intended). |
Co-authored-by: Klaus Hipp <[email protected]>
94978e0
to
0620113
Compare
There's no hard and fast rule here, but we have turned down other "Enterprise" software in the past for this because of registration links, license agreements, or other difficulties. When an organization does stuff like this w.r.t download forms, it's suggestive they want to control the flow of downloads more than they want the software to be distributed easily - and for "enterprise software" like this it probably makes sense for them to do just that. There's also consideration if enterprises are going to provide from their internal packaging because of the rigors of specific licensing or baked in configuration requirements (and if I were running an enterprise software deployment program, I'd be controlling this software in that manner) Not saying that logic applies here directly to this Cask, but I would not be surprised if this is more aligned to the actual use case, broadly. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free - See belowbrew style --fix <cask>
reports no offenses.I've updated the livecheck since the homepage seems to have been deleted. This can't be merged however since I do not know what to put as the homepage now. If you have any idea please tell me.