-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalCan 2.3.4 (new cask) #182809
LocalCan 2.3.4 (new cask) #182809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @paour! I left a few suggestions below. Please also remove any generated comments.
I'm not sure why one wouldn't use the GitHub page for the downloads? https://github.com/LocalCan/LocalCanApp This app doesn't meet the notability requirements. |
The author uses Github for distribution and support only. The releases page seems to be updated only sporadically, which is why I didn't use it. As for notability, since it's not an open-source project, I don't know what the metric should be. It does have 283 followers on ProductHunt. |
The GitHub notability check doesn't apply here because GitHub is only used for releasing the software not the source code. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.