Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalCan 2.3.4 (new cask) #182809

Merged
merged 1 commit into from
Aug 20, 2024
Merged

LocalCan 2.3.4 (new cask) #182809

merged 1 commit into from
Aug 20, 2024

Conversation

paour
Copy link
Contributor

@paour paour commented Aug 19, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @paour! I left a few suggestions below. Please also remove any generated comments.

Casks/l/localcan.rb Outdated Show resolved Hide resolved
Casks/l/localcan.rb Show resolved Hide resolved
Casks/l/localcan.rb Outdated Show resolved Hide resolved
Casks/l/localcan.rb Outdated Show resolved Hide resolved
@krehel
Copy link
Member

krehel commented Aug 19, 2024

I'm not sure why one wouldn't use the GitHub page for the downloads? https://github.com/LocalCan/LocalCanApp

This app doesn't meet the notability requirements.

@paour
Copy link
Contributor Author

paour commented Aug 19, 2024

The author uses Github for distribution and support only. The releases page seems to be updated only sporadically, which is why I didn't use it.

As for notability, since it's not an open-source project, I don't know what the metric should be. It does have 283 followers on ProductHunt.

@bevanjkay
Copy link
Member

This app doesn't meet the notability requirements.

The GitHub notability check doesn't apply here because GitHub is only used for releasing the software not the source code.

@krehel krehel merged commit 8f28d08 into Homebrew:master Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants