flox 1.0.3 (new cask) #170971
Merged
flox 1.0.3 (new cask) #170971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
See https://flox.dev for more information.
|
Ready for another review pass. I've resolved the comments that were straightforward and answered questions on the remainder. |
|
@bevanjkay it does look like this also fails. Is going back to |
bevanjkay
approved these changes
Apr 15, 2024
|
Thank you @stahnma |
|
Thank you, @bevanjkay |
github-actions bot
pushed a commit
to MPLew-is/homebrew-vscodium
that referenced
this pull request
Apr 16, 2024
flox 1.0.3 (new cask)
stahnma
added a commit
to flox/homebrew-cask
that referenced
this pull request
Apr 16, 2024
`brew uninstall --cask flox` fails if not done immediately following an installation. During review of Homebrew#170971 we saw a failure on uninstall if it happened _right_ after installation since the installation kicks off an indexing job via a process named `pkgdb`. That is killed via `early_script` in the cask. (We tried `quit` and `signal` but neither worked). However, if you want to perform an uninstallation after the index job has completed, there is no `pkgdb` process running. This change adds `must_succeed: false` to the `early_quit` stanza, so in the event the kill doesn't match any process, the uninstallation will continue normally.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://flox.dev for more information.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.